Shell > generate all screenshots by mmathieum · Pull Request #65 · mtransitapps/commons-android

mmathieum · 2026-02-17T19:45:03Z

No description provided.

gemini-code-assist · 2026-02-17T19:45:20Z

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new automation script to streamline the generation of all application screenshots, significantly reducing manual effort for localization and release processes. Concurrently, it refactors existing utility scripts to ensure a consistent and robust method for referencing the project's root directory and shared common functions, enhancing overall script reliability.

Highlights

New Screenshot Generation Script: A new shell script, pub/all-app-screenshots.sh, has been added to automate the process of generating all application screenshots across different languages and kinds. This script iterates through defined directories, creates placeholder files if necessary, and calls module-app-screenshot.sh for each.
Standardized Root Directory Sourcing: Several existing shell scripts (generate_all_dpis_from_xxxhdpi.sh, main-app-screenshot.sh, module-app-screenshot.sh, module-featured-graphic.sh, module-hi-res-app-icon.sh, module-res-mipmap-launcher-icon.sh) have been updated to consistently define the ROOT_DIR variable before sourcing commons.sh. This improves script maintainability and clarity.

Changelog

pub/all-app-screenshots.sh
- Added a new script to automate the generation of all app screenshots for various languages and kinds.
pub/generate_all_dpis_from_xxxhdpi.sh
- Updated to explicitly define ROOT_DIR before sourcing commons.sh.
pub/main-app-screenshot.sh
- Updated to explicitly define ROOT_DIR before sourcing commons.sh.
pub/module-app-screenshot.sh
- Updated to explicitly define ROOT_DIR before sourcing commons.sh.
pub/module-featured-graphic.sh
- Updated to explicitly define ROOT_DIR before sourcing commons.sh.
pub/module-hi-res-app-icon.sh
- Updated to explicitly define ROOT_DIR before sourcing commons.sh.
pub/module-res-mipmap-launcher-icon.sh
- Updated to explicitly define ROOT_DIR before sourcing commons.sh.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new script to automate the generation of all app screenshots and refactors several existing scripts to improve consistency. The changes are a good step forward. My review includes suggestions to enhance the shell scripts by following best practices, such as using parameter expansion for efficiency, removing redundant code, and improving code style for better readability and maintainability. All original comments have been kept as they align with general shell scripting best practices and do not contradict the provided rules.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

- commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support

…parser': - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support - parser: Set default value for routeId in RouteColor data class - parser: JSON config > fail parsing if invalid (missing:OK), add "route_id_to_route_short_name_configs", "direction_splitter_enabled", "stop_headsign_cleanup_regex" ...

- commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support

…mtransitapps/commons-android#65

- commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class

…er': - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class - parser: JSON config > fail parsing if invalid (missing:OK), add "route_id_to_route_short_name_configs", "direction_splitter_enabled", "stop_headsign_cleanup_regex" ...

- commons: CI > screenshots > fix no module APK when built - commons: CI > screenshots > fix no module APK log - commons: CI > screenshots > fix no module APK - commons: Add build-from-source fallback for screenshot workflow when no release exists mtransitapps/commons#588 - commons: Add workflow for recording Android screenshots with hardware-accelerated emulator mtransitapps/commons#578 - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support

…parser': - commons: CI > screenshots > fix no module APK when built - commons: CI > screenshots > fix no module APK log - commons: CI > screenshots > fix no module APK - commons: Add build-from-source fallback for screenshot workflow when no release exists mtransitapps/commons#588 - commons: Add workflow for recording Android screenshots with hardware-accelerated emulator mtransitapps/commons#578 - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons: Address comment from mtransitapps/commons#576 - commons: CI > release workflow mtransitapps/commons#576 - commons: FF ON to export Vehicle Location providers in module apps mtransitapps/commons#556 - commons: CI > Enable/disable Store channels mtransitapps/commons#573 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - commons-android: YouTube providers > clean severity&noteworthy defaults - commons-android: Twitter/RSS providers > clean severity&noteworthy defaults - commons-java: Strings cleaner > FR support - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class - parser: JSON config > fail parsing if invalid (missing:OK), add "route_id_to_route_short_name_configs", "direction_splitter_enabled", "stop_headsign_cleanup_regex" ...

- commons: CI > screenshots > fix no module APK when built - commons: CI > screenshots > fix no module APK log - commons: CI > screenshots > fix no module APK - commons: Add build-from-source fallback for screenshot workflow when no release exists mtransitapps/commons#588 - commons: Add workflow for recording Android screenshots with hardware-accelerated emulator mtransitapps/commons#578 - commons: Add allowNonDefault input to mt-release workflow mtransitapps/commons#587 - commons: Add workflow inputs to skip store releases in mt-release.yml mtransitapps/commons#586 - commons: Build(deps): Bump com.google.android.gms:play-services-ads from 24.9.0 to 25.0.0 in the gms group mtransitapps/commons#580 - commons: Update script to skip publishing if no current users mtransitapps/commons#582 - commons: Build(deps): Bump android-gradlePlugin from 9.0.0 to 9.0.1 mtransitapps/commons#581 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.5 to 2.3.6 in the kotlin-ksp-compose group mtransitapps/commons#579 - commons-android: RSS news > use link (regex+format) to generate date (no `pubDate`) #BCTransit mtransitapps/commons-android#68 - commons-android: Modify network command broadcasts for demo - commons-android: Update network command to hide WiFi and show 5G mtransitapps/commons-android#67 - commons-android: Adjust sleep duration based on CI environment mtransitapps/commons-android#66 - commons-android: Shell > generate all screenshots mtransitapps/commons-android#65 - parser: Migrate GTFS documentation links from developers.google.com to gtfs.org mtransitapps/parser#37 - parser: Set default value for routeId in RouteColor data class

Shell > generate all screenshots

25e86cc

mmathieum self-assigned this Feb 17, 2026

gemini-code-assist Bot reviewed Feb 17, 2026

View reviewed changes

mmathieum and others added 8 commits February 17, 2026 14:48

Update pub/all-app-screenshots.sh

711cb56

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/all-app-screenshots.sh

8863a93

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/generate_all_dpis_from_xxxhdpi.sh

8480f5b

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/main-app-screenshot.sh

7e9317e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/module-app-screenshot.sh

d13e220

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/module-featured-graphic.sh

83e6009

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/module-hi-res-app-icon.sh

72b2698

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update pub/module-res-mipmap-launcher-icon.sh

e731e8a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

mmathieum mentioned this pull request Feb 18, 2026

Create CI workflow to record new screenshots mtransitapps/commons#577

Closed

mmathieum marked this pull request as ready for review February 18, 2026 19:43

mmathieum merged commit e67e5ec into master Feb 18, 2026
4 checks passed

mmathieum deleted the mm/all_app_screenshots_sh branch February 18, 2026 19:44

mmathieum pushed a commit to mtransitapps/mtransit-for-android that referenced this pull request Feb 20, 2026

CI: Sync code from 'commons-android': Shell > generate all screenshots …

eab37c1

…mtransitapps/commons-android#65

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shell > generate all screenshots#65

Shell > generate all screenshots#65
mmathieum merged 9 commits into
masterfrom
mm/all_app_screenshots_sh

mmathieum commented Feb 17, 2026

Uh oh!

gemini-code-assist Bot commented Feb 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mmathieum commented Feb 17, 2026

Uh oh!

gemini-code-assist Bot commented Feb 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant