Skip to content

Remove unnecessary RESULT variable in publish_to_current_users.sh#584

Merged
mmathieum merged 3 commits into
mm/skip_no_current_users_instead_or_errorfrom
copilot/sub-pr-582
Feb 19, 2026
Merged

Remove unnecessary RESULT variable in publish_to_current_users.sh#584
mmathieum merged 3 commits into
mm/skip_no_current_users_instead_or_errorfrom
copilot/sub-pr-582

Conversation

Copilot AI commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Addresses feedback from PR #582 review comment about unnecessary variable usage when checking script exit codes.

Changes

  • Replaced three-line exit handling pattern with single-line || exit
  • Removed all RESULT variable assignments

Before:

$SCRIPT_DIR/publish_to_alpha.sh;
RESULT=$?;
[[ ${RESULT} != 0 ]] && exit ${RESULT};

After:

$SCRIPT_DIR/publish_to_alpha.sh || exit;

The || exit pattern preserves exit codes correctly: when a command fails, exit without arguments uses the exit status of that failed command (last command executed).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 19, 2026 14:16
Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>
Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>
Copilot AI changed the title [WIP] Update publishing script to address RESULT variable feedback Remove unnecessary RESULT variable in publish_to_current_users.sh Feb 19, 2026
Copilot AI requested a review from mmathieum February 19, 2026 14:19
@mmathieum mmathieum marked this pull request as ready for review February 19, 2026 14:24
@mmathieum mmathieum merged commit cbdd603 into mm/skip_no_current_users_instead_or_error Feb 19, 2026
@mmathieum mmathieum deleted the copilot/sub-pr-582 branch February 19, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants