Add named frames to CollisionObjects#50
Conversation
BryceStevenWilley
left a comment
There was a problem hiding this comment.
LGTM, with one correction.
rhaschke
left a comment
There was a problem hiding this comment.
I generally approve this. Not sure yet, whether we really need the ValidateConstraintFrames service.
Shouldn't this be called TransformConstraintFrames, because it's main task is to transform the transforms into known link transforms.
|
All of the alternatives I could come up with are somewhat imprecise and can be misunderstood. In my mind, the important point is that the constraints are changed from an unusable/invalid state to a formulation that the planner can use. I considered others, too:
I think naming and readibility is important, so I'm all for being verbose if it helps understanding. The function does not come up often anyway, so it won't clog any code. |
This (partially) reverts commit 6350bfb. We keep the improvements in the comments.
This belongs to ros-planning/moveit#1060 and fixes #47 (now properly targets melodic, not kinetic).