Add named frames to CollisionObjects#47
Closed
felixvd wants to merge 22 commits intomoveit:kinetic-develfrom
Closed
Add named frames to CollisionObjects#47felixvd wants to merge 22 commits intomoveit:kinetic-develfrom
felixvd wants to merge 22 commits intomoveit:kinetic-develfrom
Conversation
Add fields to store planning time in pick-and-place
Member
davetcoleman
left a comment
There was a problem hiding this comment.
we should target melodic so we don't break message compatibility in a 2 year old LTS... what OS are you working on?
msg/CollisionObject.msg
Outdated
| # to plan with (e.g. screwdriver_tip, kettle_spout, mug_base). | ||
| # The length of these vectors has to be identical. | ||
| string[] frame_names | ||
| geometry_msgs/Pose[] named_frames |
Member
There was a problem hiding this comment.
rename to frame_poses so it matches frame_names?
Contributor
Author
|
I'm on 16.04 with this system. I can try it out on melodic from November. I added the changes, but the GetConstraintValidity service might get dropped, as mentioned in the other PR. |
…end-planning-scene
Member
|
Did you mean to close this? |
Contributor
Author
|
I'm not sure what happened, but either way this PR needed to go against melodic, not kinetic, as you said. I'm reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This belongs to moveit/moveit#1060