Skip to content

Add fields to store planning time in pick-and-place#43

Merged
130s merged 1 commit intomoveit:melodic-develfrom
aochiai:pick-place-planning-time
Apr 17, 2018
Merged

Add fields to store planning time in pick-and-place#43
130s merged 1 commit intomoveit:melodic-develfrom
aochiai:pick-place-planning-time

Conversation

@aochiai
Copy link
Copy Markdown
Contributor

@aochiai aochiai commented Mar 7, 2018

Add new fields to store planning time of the pick-and-place capability.
MoveGroup.action already has this.

@davetcoleman
Copy link
Copy Markdown
Member

This will break ABI in a difficult way for Kinetic. I believe this should be merged into ROS-M, which we haven't branched for yet. We are having a maintainer meeting on March 20th and will be discussing branching. Would you like to join this discussion?

@aochiai
Copy link
Copy Markdown
Contributor Author

aochiai commented Mar 8, 2018

It makes sense to me to put this off until ROS-M.
I'm interested in the maintainer meeting. (Mostly out of curiosity)
Please let me know when you find out the holding time.

@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Mar 8, 2018

I agree, we should not merge this into kinetic.
Let's discuss more in the meeting.

@davetcoleman
Copy link
Copy Markdown
Member

@aochiai please email me so I can invite you.
dave@picknik.ai

@davetcoleman davetcoleman changed the base branch from kinetic-devel to melodic-devel April 11, 2018 04:35
@davetcoleman
Copy link
Copy Markdown
Member

@aochiai I have created the new branch

@130s 130s merged commit 424a377 into moveit:melodic-devel Apr 17, 2018
# The performed grasp, if attempt was successful
Grasp grasp

# The amount of time in seconds it took to complete the plan
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ambiguous. Is it the time to plan or the time to execute the plan? Maybe reword to "it took to generate a plan"

# The successful place location, if any
PlaceLocation place_location

# The amount of time in seconds it took to complete the plan
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ambiguous. Is it the time to plan or the time to execute the plan? Maybe reword to "it took to generate a plan"

@mlautman
Copy link
Copy Markdown

mlautman commented Jun 8, 2018

@aochiai Can you rewrite the comment to make it less ambiguous in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants