Skip to content

Pass robot_description parameter in RobotCommander.get_group#781

Closed
rkeatin3 wants to merge 5 commits intomoveit:indigo-develfrom
rkeatin3:indigo-devel
Closed

Pass robot_description parameter in RobotCommander.get_group#781
rkeatin3 wants to merge 5 commits intomoveit:indigo-develfrom
rkeatin3:indigo-devel

Conversation

@rkeatin3
Copy link
Copy Markdown
Contributor

@rkeatin3 rkeatin3 commented Feb 22, 2018

Description

When using a parameter other than "/robot_description", RobotCommander.get_group() will fail in creating a MoveGroupCommander. The name of the parameter needs to be passed.

Checklist

  • Required: Code is auto formatted using clang-format
    Not applicable. My changes are PEP-8 compliant, though.

I realize that it would have been cleaner to reset my indigo-devel to origin/indigo-devel rather than merge. I can redo this PR if that's at all problematic.

@rkeatin3
7f04d27 
Exclude passive joints from trajectories to execute and the lists for fake controllers.
@rkeatin3
cf6b318 
Reformatting changes with clang-format-3.8.
@rkeatin3
Merge remote-tracking branch 'origin/indigo-devel' into indigo-devel
2e354ed
@rkeatin3
289067a 
Pass robot_description parameter on creating MoveGroup (otherwise it will look in "/robot_description").
@rkeatin3
ac77f1f 
Fixed for apparent member variable naming convention.
@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Feb 22, 2018

👍 but looking at the commits this should definitely be a squash merge

@rkeatin3
Copy link
Copy Markdown
Contributor Author

rkeatin3 commented Feb 22, 2018

Agreed. Resetting my branch to origin/indigo-devel from my previous PR would have avoided part of that headache, yeah?

Any other feedback appreciated, as I'm fairly new to git and very new to open-source software development.

@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Feb 23, 2018 •
edited
Loading

No worries about that, doing great.

I do have to add a new note though...It is preferred to submit PR-s against kinetic-devel (where the same issue persists) as that is our current main branch. In the submission of the PR you can then recommend the PR to be cherry-picked back to Indigo too. Please submit a new PR against kinetic-devel. It will be the same changes, it's also a good opportunity to clean up the commit log :) Once submtited the new one, you can close this PR.

@rkeatin3
Copy link
Copy Markdown
Contributor Author

rkeatin3 commented Feb 23, 2018

Sure thing, will do.

It's easy to verify kinetic-devel has the same issue in this case. In the case that it isn't or that I have to touch the C++, are there any ways for me to help you maintainers given that I don't have a machine with 16.04/Kinetic?

Thanks for the input!

@rkeatin3 rkeatin3 mentioned this pull request Feb 23, 2018
Merged
@rkeatin3
Copy link
Copy Markdown
Contributor Author

rkeatin3 commented Feb 23, 2018

See new PR for kinetic-devel: #782.

@rkeatin3 rkeatin3 closed this Feb 23, 2018
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
@henningkayser @lapo5
MoveitCpp - path constraints added from PlanningComponent (backport m…
f96c84c 
…oveit#752) (moveit#781)

Co-authored-by: Marco Lapolla <marco.lapolla5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkeatin3 @bmagyar