Pass robot_description parameter in RobotCommander.get_group #782
Merged
rhaschke merged 2 commits intomoveit:kinetic-develfrom Apr 3, 2018
rkeatin3:kinetic-devel
Merged
Pass robot_description parameter in RobotCommander.get_group #782rhaschke merged 2 commits intomoveit:kinetic-develfrom rkeatin3:kinetic-devel
rhaschke merged 2 commits intomoveit:kinetic-develfrom
rkeatin3:kinetic-devel
Conversation
Contributor
Author
|
Once again, I forgot to update my |
1 task
davetcoleman
approved these changes
Mar 29, 2018
Member
|
@mlautman please review |
Member
|
You can also rebase, now this PR needs to be squash-merged. LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #781.
Description
When using a parameter other than "/robot_description",
RobotCommander.get_group()will fail in creating aMoveGroupCommander. The name of the parameter needs to be passed.