Bring add-subtopology branch up to date#7
Merged
moisesmata merged 22 commits intoadd-subtopologiesfrom Jun 17, 2025
Merged
Conversation
…nasa#3695) * PRIVATE->private and PROTECTED->protected updates in Svc/BufferLogger (nasa#3446) * Add comments about fwd declaration (nasa#3446) * PRIVATE->private and PROTECTED->protected updates in Svc/CmdSequencer (nasa#3446)
…SDD (nasa#3697) * Adding note about explicitly identifying ports that need priority in SDD * Corrected type: FDD -> FPP
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix ambiguous error for .serialize overloads * change to U32 cast * change to FwPacketDescriptorType cast
* Fixing immplementation of UDP epehmeral support and adding two tests cases to TestUdp * Updating SDD. Fixing configureSend so it can be passed a port of 0. * Actually adding SDD this time. Also fixed some incorrect wording in hpp file. * Removing unnecessary period * Removing redundant test. All the functionality can be tested in the same test. * Removing redundant code path. * Incorporating some fixes for static analysis findings * Revert "Incorporating some fixes for static analysis findings" This reverts commit 644fbbe. * Incorporating some fixes to static analyzer findings. * Fixing typo * Changing use of char to CHAR * Adding documentation for ephemeral ports to Drv/Ip SDD. Fixing configureSend so that it maintains the configured timeout_seconds and timeout_microseconds. * Adding netinet to spelling expect list. * Changing the use of socklen_t to U32 * Incorporating PR suggestion * Reverting back to using socklen_t for address length
* First pass at Svc + TcpClient implementation * Tmp work * Revert FileUplink changes * Add copy (with allocation/deallocation) to FprimeRouter to simplify buffer management * Update FprimeRouter UTs * Update FprimeDeframer UTs * Update FrameAccumulator UTs * Update ComStub UTs * Update missing Drv and UTs * Update ComInterface to use ComDataWithContext on output * Update Ref/RPI topology * Fix spelling * Fix test typo * Update Udp component and UTs * Rename data ports and standardize "Return" naming pattern * Fix variable name * Adapt UTs * Update Communication Adapter Interface docs * Full SDD updates * Spelling & nits and details * Put formatting back to original * Added SpacePacket, TC and TM framers/deframers + Ref topology. Working with GDS wohooo * TODOs and code cleanup * Add APID enum to ComCfg.fpp and route based on received APID * Increment counts per frame/apid * Remove duplicate files * Document and implement services/functions provided by the TCDeframer * Add events, todos and notes * fill TM frame with idle packet * Add ApidMapper component and map APID - FwPacketDescriptor * Refactor to new CMake API * Update Types and Add TCDeframer tests * Update type usage namespacing * Finish TCDeframer UTs * Add TMFramer tests and refine VcId handling * Tests and code cleanup * Define ComPacketType in FPP * Map FW_PACKET_FILE to downlink specific APID * Remove sequence number check * Add packet loss notification to space packet * Tests WIP * WIP * Use SpacePacket header type in TMFramer idle packet * SpacePacketDeframer tests and untracked APID detection * Add APID (=PacketDescriptor) extraction to FprimeDeframer * Use ApidManager on uplink to validate seq count (is central authority for APID - SeqCount) * Code cleanup * Much cleaner ApidManager as a service, not in the middle of framing * Even better ApidManager * Add SpacePacketFramer UTs * Set up rule based testing for ApidManager * Code cleanup and fix TMFramer UT * First pass at SDDs and stuff * SDD fixes * ApidManager Rule-based testing * Improve TMFramer code coverage, docs and comments * Types cleanup * Add CRC check to CcsdsTCFrameDetector * Add unit tests for CcsdsTCFrameDetector * Fix Ref topology * Fix old PacketType usage * Fix ComQueue UTs * Fix CI warnings * Add test for CRC corruption in frame detector * Spelling * Remove ApidDemo component from topology * Fix more static analysis * Clean up ApidManager tests and fix static analysis warnings * Fix UTs on RHEL8 * Fix SDD links * Fix more static analysis on UTs * More spelling fixes * Improve SDDs and comments * Update metadata check-spelling run (pull_request_target) for ccsds-protocols Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev> * More SDD updates * Attempt UT fixes * First pass of review comments * Fix length token is minus 1 inconsistency * Review recs: static assert frame size, docs, TM buffer asserts * Add fprime-gds.yml to Ref for GDS with framing selection * Update requirements.txt for GDS 4.0.0a3 (CCSDS protocols) * Update UTs to reflect last update * Drop Python 3.8 support * Update FprimeRouter UTs for new APID routing * Fix spelling and RHEL8 cast warnings * Fix spelling again... * Deserialize APID in FprimeDeframer only if it is valid * Fix googletest warning?? * static casting that u8 yall * Use width FPP constants * Add SDD links * Switch TMFramer/TCDeframer capitalization to TmFramer/TcDeframer * Use git mv to rename files and directory * oops forgot rename a test file * review changes: add annotations on all FPP ports --------- Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> Co-authored-by: Thomas Boyer-Chammard <thomas-bc@users.noreply.github.com>
* Scrubbing XML * sp
* Add RHEL8 container to CI * Trigger on ci/ branches * remove trigger on examples * Attempt to install deps in container * remove sudo * git safe directory * install libasan * Add libasan libubsan * fix spelling * Add test user for UT run
* Fixing directory detection bug. * Removed some superfluous whitespace * Adding branch path for non-directory and non-file to return PathType::OTHER. Fixing a spelling mistake. * Moving getPathType to OS specific FileSystem implementations * Incorporating PR comments and cleaning up comments * Reverting unnecessary comment changes * Incorporating fixes for static analysis findings
* Added led-blinker workflow for aarch64-linux platform * Update runner label * Added Tags to RPI self hosted workflows, sparse-checkout-cone-mode false * Add subtopologies to Svc/ restructing of Ref to include CDH subtopology * CDHCore Subtopology added under Svc and integrated into Ref * Health instance within CDHCore references CDHCoreConfig for queue size * Update metadata check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev> * Added AssertFatalAdapter Version PassiveTextLogger to Subtopology, config clarity improvements * Comms subtopology without cmdSeq created, integrated in Ref * Added cmdSeq to Comms Subtopology, integrated into Ref * Add FileHandling Subtopology, initial structure * Fixed Spelling, Flie -> File * Update metadata check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev> * Added working FileHandling, DataProducts subtopology, integrated into Ref * prmDb part of FileHandling, fatalHandler part of CDHCore * Update metadata check-spelling run (push) for add-subtopologies Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev> * Update comment for clarity * Initial move to phasing components * Fixing Phasing: Adding initial Phasing for CDHCore, DataProducts, FileHandling * Renaming topologydefs.hpp, phasing fully working on all four subtopologies, needs cleaning up * Cleanup with Ports_ComPacketQueue, definition only in Comms.fpp now * CDHCore subtopology added and integrated within Ref deployment * Fixed to work with CCSDS, added comment on RefPackets, fatalHandler within CDHCore config * Add correct stackSize in CDHCoreconfig * CDHCore Subtopology, parameterization done through config overrides - Subtopology with core CDH functionality within Svc - integrated within Ref Deployment - PingEntries.hpp within CDHCore/ that provides default values for PingEntries - Default TlmChan, option to use TlmPacketizer through changing CDHCoreConfig.fpp * Fixed priority values in CDHCoreConfig, removed FatalHandler from CDHCore * Update metadata check-spelling run (pull_request_target) for add-cdhcore-subtopology Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev> * Added CDHCore as a dependency for TestDeployment, in CMakeLists.txt * Changed Structure in RefTopologyDefs.hpp to make simpler * Reverted to prior RefTopologydefs.hpp Structure --------- Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> Co-authored-by: Moises Mata <moisesmata@users.noreply.github.com>
* Add FwBaseIdType, updates ActiveLogger, CmdDispatcher, TlmPacketizer to use Fw types, update unit tests * Update unit tests, rename FwBaseIdType to FwIdType * Cleanup * Change type of sizeOfZeros * Add FwIdType to TestConfigDeployment overriden config * Add annotation * Update Ref linuxTimer base id
* updated supported platforms docs * Fixed Tip box * clear up doc * fixed spelling * Added nice title so the website can pick that up * correcting step * updated per pr reviews * being more consistent with the word deployment. these sentences should actually use reference project instead of reference deployment -- as discussed with the fprime core team
* Add constants to dictionary spec * Update enum section to use enum value * Update dictionary content section to include array of constants. * Remove kind field from constant * Add note on how integer constants are output to the dictionary * Add table of required defs with names, kinds, locations, and purpose
* Purging PlatformIntType and PlatformUIntType * CI fixes * Fixing review requirements * Fix CI error * Fix CI cmake test regression * Fix RHEL8 regression
* Create test case revealing issue * Refactored autocoders for clearer outputs, tests, chaining * Testing header generation * Adding test for rerunning autocoders * Fix dictionary generation and installation * Fix CMake tests by removing module-info.txt
…nasa#3737) * PRIVATE->private and PROTECTED->protected updates in Svc/FpySequencer * Clean up new UT public/private helpers * sp --------- Co-authored-by: M Starch <LeStarch@googlemail.com>
| }; | ||
|
|
||
| UdpSocket::UdpSocket() : IpSocket(), m_state(new(std::nothrow) SocketState), m_recv_port(0) { | ||
| UdpSocket::UdpSocket() : IpSocket(), m_state(new(std::nothrow) SocketState), m_recv_port(0), m_recv_configured(false) { |
Check warning
Code scanning / CppCheck
Class 'UdpSocket' does not have a copy constructor which is recommended since it has dynamic memory/resource allocation(s).
| }; | ||
|
|
||
| UdpSocket::UdpSocket() : IpSocket(), m_state(new(std::nothrow) SocketState), m_recv_port(0) { | ||
| UdpSocket::UdpSocket() : IpSocket(), m_state(new(std::nothrow) SocketState), m_recv_port(0), m_recv_configured(false) { |
Check warning
Code scanning / CppCheck
Class 'UdpSocket' does not have a operator= which is recommended since it has dynamic memory/resource allocation(s).
| Framework: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: redhat/ubi8:8.10 |
Check warning
Code scanning / check-spelling
Candidate Pattern Warning
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.