PRIVATE->private and PROTECTED->protected updates in Os/File.hpp (#3446)#3701
Merged
LeStarch merged 2 commits intonasa:develfrom Jun 11, 2025
Merged
PRIVATE->private and PROTECTED->protected updates in Os/File.hpp (#3446)#3701LeStarch merged 2 commits intonasa:develfrom
LeStarch merged 2 commits intonasa:develfrom
Conversation
LeStarch
previously approved these changes
Jun 6, 2025
thomas-bc
requested changes
Jun 6, 2025
thomas-bc
approved these changes
Jun 10, 2025
Collaborator
thomas-bc
left a comment
There was a problem hiding this comment.
LGTM! Just one quick question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updates to
Os/File.hpp:PRIVATE->privateThere were issues with existing namespaces and class names conflicting, so I first (1) updated the Os::Test::File namespace from
File->FileTestand made the corresponding updates where that namespace was used, and then (2) added afriend structuntil no build errors.