Add constants to dictionary spec#3692
Merged
LeStarch merged 6 commits intonasa:develfrom Jun 16, 2025
Merged
Conversation
LeStarch
reviewed
Jun 4, 2025
Collaborator
LeStarch
left a comment
There was a problem hiding this comment.
Some basic questions/suggestions
thomas-bc
reviewed
Jun 4, 2025
Collaborator
|
Let's make sure that the JSON spec lists all the FPP symbols that are implicitly required in the model when you generate a dictionary. I think the JSON spec should be the source of truth for this list as it evolves. I've updated the FPP docs under the assumption that this list is available: https://github.com/nasa/fpp/wiki/Construct-Implied-Use-Map#topology-definitions. |
LeStarch
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updated JSON dictionary spec to include constants and constant values. Also cleaned up Array, Enum, and Struct section to reference array values, enum values, and struct values.
Rationale
Spec updates were needed since we are adding some constants to the dictionary in nasa/fpp#729.