Require DP constants and enums in dictionary#729
Closed
Require DP constants and enums in dictionary#729
Conversation
bocchino
reviewed
Jun 6, 2025
bocchino
reviewed
Jun 6, 2025
compiler/lib/src/main/scala/analysis/CheckSemantics/CheckUses.scala
Outdated
Show resolved
Hide resolved
bocchino
reviewed
Jun 6, 2025
compiler/lib/src/main/scala/analysis/CheckSemantics/ConstructDictionaryMap.scala
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Going to update the users guide with info on the types that are required by the dictionary. |
bocchino
reviewed
Jun 11, 2025
bocchino
requested changes
Jun 11, 2025
Collaborator
bocchino
left a comment
There was a problem hiding this comment.
Looks good! Can you please make the following minor changes:
- In Section 14.8 of the User's Guide, complete the table that I started, and remove the text that is to be moved into the table.
- In the fpp-to-dict tests, add a test for the case where a required constant is present, but it has a non-integer type.
bocchino
reviewed
Jun 11, 2025
Collaborator
|
Let's hold off work on this PR until #740 is complete. Some rework will be required, but I think this PR will actually be easier once that refactoring is done. |
Collaborator
Author
|
Created new PR for this change #742 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require that the following types are defined and output them to the dictionary:
Aliases
Enums
Constants
Closes #719.
Spec updates are done in nasa/fprime#3692.