ping @andrewhsu for review

Can you summarise the relevant changes? (perhaps link to those PR's where needed?)

The comparison of changes above has all the commits, which is a pretty good summary. LMK if more details are needed @thaJeztah

$ git log --oneline de950a7...4429c76 | grep 'Merge pull request' | awk '{print"docker/swarmkit" $5}' # list of swarmkit PRs in this vndr update

• Manager Instrumentation swarmkit#2356 Manager Instrumentation
• Revert grpc max message size/large timeout workaround for snapshot shipping between raft nodes swarmkit#2464 Revert grpc max message size/large timeout workaround for snapshot shipping between raft nodes
• Snapshot streaming swarmkit#2458 Snapshot streaming
• Carry "Don't delete tasks until they're actually removed by the agent" swarmkit#2461 Carry "Don't delete tasks until they're actually removed by the agent"
• Replace deprecated grpc.Errorf() with status.Errorf() swarmkit#2440 Replace deprecated grpc.Errorf() with status.Errorf()
• Regenerate protobuf for 3.5 swarmkit#2451 Regenerate protobuf for 3.5
• Update protobuf to 3.5.0 swarmkit#2448 Update protobuf to 3.5.0
• Update with make generate. swarmkit#2447 Update with make generate.
• Error on cluster spec name change. swarmkit#2436 Error on cluster spec name change.
• Adding logging to keymanager and cluster store object create. swarmkit#2422 Adding logging to keymanager and cluster store object create.
• Avoid running plugin filter when Log Driver does not have a Name swarmkit#2438 Avoid running plugin filter when Log Driver does not have a Name
• Welcome anshulpundir to MAINTAINERS swarmkit#2431 Welcome anshulpundir to MAINTAINERS
• issue 2401 - normalize "aarch64" architectures to "arm64" swarmkit#2411 issue 2401 - normalize "aarch64" architectures to "arm64"
• Update Misty's GitHub handle swarmkit#2423 Update Misty's GitHub handle

BTW, I see some tests failing in janky because of the changes being pulled in. Looks like the tests will have to be modified/fixed.

@dperny for review

LGTM, but I am not a maintainer. The extra commit should fix a failing test.

@nishanttotla @dperny does this fix:

• cross build and architecture labeling #35158 (through issue 2401 - normalize "aarch64" architectures to "arm64" swarmkit#2411)?
• service ps not showing all instances after scaling down #34967 and Container continues to run even though swarm reports it's gone already #34574 (through Carry "Don't delete tasks until they're actually removed by the agent" swarmkit#2461 / Don't delete tasks until they're actually removed by the agent swarmkit#2446) ?

#34967 should be fixed by moby/swarmkit#2461 / moby/swarmkit#2446, but I don't think this was tested. I don't know if it fixes #34574 (also not tested after moby/swarmkit#2461 / moby/swarmkit#2446 went in) @thaJeztah

We only have unit tests for moby/swarmkit#2461 / moby/swarmkit#2446, but it would be advisable to add end to end testing as well. I do believe that #34574 is fixed by those PRs.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "vndr" git@github.com:anshulpundir/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354331352
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM