Revert grpc max message size/large timeout workaround for snapshot shipping between raft nodes#2464
Conversation
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
|
Please sign your commits following these rules: $ git clone -b "snap_reset" git@github.com:anshulpundir/swarmkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354330304
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
…shots" This reverts commit e3e2821. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
ef0fccb to
82d959c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
+ Coverage 61.66% 61.68% +0.01%
==========================================
Files 128 128
Lines 21076 21069 -7
==========================================
- Hits 12997 12996 -1
+ Misses 6677 6657 -20
- Partials 1402 1416 +14 |
|
We should hold off on reverting the max message size for a release so that clusters with different versions interoperate more smoothly. |
|
I disagree, mainly because keeping this would only be useful in cases which should not be supported e.g. trying to add a new manager with an older version of swarmkit where the leader already supports streaming, or upgrading a worker running an older version to a manager where the leader has already been upgraded. |
|
SGTM, LGTM, you have my approval. |
|
LGTM I'm assuming we have some regression testing for this. |
I'll make sure we do. |
Since we can now stream snapshots between raft nodes, we can revert the grpc workarounds.