Merged
Conversation
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Collaborator
|
LGTM, FWIW, but I honestly don't know much about this file. @stevvooe WDYT? Looks fine? |
thaJeztah
reviewed
Nov 15, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM - this is the same result I saw
stevvooe
approved these changes
Nov 15, 2017
Contributor
|
Explaining what is happening here: looks like a new descriptor was picked up in the api set with new fields. These were added to the upstream protobuf project. |
nishanttotla
approved these changes
Nov 15, 2017
Codecov Report
@@ Coverage Diff @@
## master #2447 +/- ##
==========================================
- Coverage 63.74% 61.22% -2.53%
==========================================
Files 64 128 +64
Lines 11793 26412 +14619
==========================================
+ Hits 7518 16171 +8653
- Misses 3663 8840 +5177
- Partials 612 1401 +789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anshul Pundir anshul.pundir@docker.com