issue 2401 - normalize "aarch64" architectures to "arm64"#2411
Merged
nishanttotla merged 1 commit intomoby:masterfrom Nov 2, 2017
crunchywelch:2401-arm64_support
Merged
issue 2401 - normalize "aarch64" architectures to "arm64"#2411nishanttotla merged 1 commit intomoby:masterfrom crunchywelch:2401-arm64_support
nishanttotla merged 1 commit intomoby:masterfrom
crunchywelch:2401-arm64_support
Conversation
Signed-off-by: Aaron Welch <welch@packet.net>
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
==========================================
+ Coverage 60.51% 60.61% +0.09%
==========================================
Files 128 128
Lines 26339 26345 +6
==========================================
+ Hits 15940 15968 +28
+ Misses 9004 8985 -19
+ Partials 1395 1392 -3 |
This was referenced Oct 13, 2017
Contributor
nishanttotla
left a comment
There was a problem hiding this comment.
The code looks fine, but I think we need to address the concerns discussed in moby/moby#35158 (comment) (and the issue in general).
Contributor
|
cc @stevvooe |
Contributor
|
LGTM Long term, we can move to the containerd platforms package, which encodes all of these normalizations. |
nishanttotla
approved these changes
Nov 2, 2017
marcusmartins
added a commit
to marcusmartins/docker
that referenced
this pull request
Nov 3, 2017
Upgrade swarmkit dependency. Changes: moby/swarmkit@ce5f7b8a (HEAD -> master, origin/master, origin/HEAD) Merge pull request moby/swarmkit#2411 from crunchywelch/2401-arm64_support moby/swarmkit@b0856099 Merge pull request moby/swarmkit#2423 from thaJeztah/new-misty-handle moby/swarmkit@2bd294fc Update Misty's GitHub handle moby/swarmkit@0769c605 Comments for orphaned state/task reaper. (moby/swarmkit#2421) moby/swarmkit@de950a7e Generic resource cli (moby/swarmkit#2347) moby/swarmkit@312be598 Provide custom gRPC dialer to override default proxy dialer (moby/swarmkit#2419) moby/swarmkit@4f12bf79 Merge pull request moby/swarmkit#2415 from cheyang/master moby/swarmkit@8f9f7dc1 add pid limits moby/swarmkit@da5ee2a6 Merge pull request moby/swarmkit#2409 from dperny/workaround-attachments moby/swarmkit@0c7b2fc2 Delete node attachments when node is removed moby/swarmkit@9d702763 normalize "aarch64" architectures to "arm64" moby/swarmkit@28f91d8...ce5f7b8 Signed-off-by: Marcus Martins <marcus@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hanging off issue #2401 add mapping for aarch64 to arm64