Skip to content

[carry 19752] vendor: update runc/libcontainer to v0.0.8#20187

Merged
LK4D4 merged 1 commit intomoby:masterfrom
cyphar:vendor-runc
Feb 17, 2016
Merged

[carry 19752] vendor: update runc/libcontainer to v0.0.8#20187
LK4D4 merged 1 commit intomoby:masterfrom
cyphar:vendor-runc

Conversation

@cyphar
Copy link
Copy Markdown
Contributor

@cyphar cyphar commented Feb 10, 2016

For a list of changes, see https://github.com/opencontainers/runc/releases/tag/v0.0.8

Closes #19752

Signed-off-by: Aleksa Sarai asarai@suse.com

This depends on opencontainers/runc#552. Everything this depends on has been merged.

/cc @jfrazelle @crosbymichael @icecrime

@cyphar cyphar mentioned this pull request Feb 10, 2016
Closed
@cyphar
Copy link
Copy Markdown
Contributor Author

cyphar commented Feb 10, 2016

The windows failures aren't caused by this PR.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Feb 10, 2016

LGTM, thanks for carrying @cyphar

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Feb 10, 2016

@cyphar btw there is 0.0.8 :/

@cyphar cyphar force-pushed the vendor-runc branch 2 times, most recently from 2aada15 to 090fecb Compare February 10, 2016 23:15
@cyphar cyphar changed the title [carry 19752] vendor: update runc/libcontainer dependency to v0.0.7 [carry 19752] vendor: update runc/libcontainer to v0.0.8 Feb 10, 2016
@cyphar
Copy link
Copy Markdown
Contributor Author

cyphar commented Feb 10, 2016

@LK4D4 I've bumped it to v0.0.8.

@cyphar
Copy link
Copy Markdown
Contributor Author

cyphar commented Feb 11, 2016

Thank goodness I added a regression test for invalid cgroup paths. This could've ended badly. runC also broke that. o.O

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Feb 11, 2016

@cyphar Seems like something with vendor.

@cyphar
Copy link
Copy Markdown
Contributor Author

cyphar commented Feb 12, 2016

@LK4D4 Yeah, I've added some fixes that haven't yet been merged into runC (so I haven't updated hack/vendor.sh or someone might merge it). I'll fix this once the fixes have been merged (opencontainers/runc#552).

@cyphar cyphar mentioned this pull request Feb 15, 2016
Merged
@cyphar cyphar force-pushed the vendor-runc branch 6 times, most recently from 8337e32 to adc85bc Compare February 17, 2016 04:33
@cyphar
Copy link
Copy Markdown
Contributor Author

cyphar commented Feb 17, 2016

For some reason, vendor seems keen to drop the entirety of gopkg.in/fsnotify.v1 ... I'll look into this later.

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Feb 17, 2016

@cyphar yes, it's weird, it used in pkg/filenotify. ping @cpuguy83

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Feb 17, 2016

Yeah, this is because vebdor.sh will drop anything not used by the core. We don't use the file notify package anymore, so it's deps are being dropped.
Can make a or to remove it.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Feb 17, 2016

@cpuguy83 that'd be great, I think this PR is currently blocking #19244 and #18697

@cyphar
Copy link
Copy Markdown
Contributor Author

cyphar commented Feb 17, 2016

@cpuguy83 @LK4D4 @thaJeztah Alright, I've opened a new PR to remove fsnotify: #20396.

@cyphar
vendor: update runc/libcontainer
093dd39 
This includes all of v0.0.8 as well as a few bug fixes that popped up
during vendoring.

Signed-off-by: Aleksa Sarai <asarai@suse.com>
@calavera
Copy link
Copy Markdown
Contributor

calavera commented Feb 17, 2016

LGTM

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Feb 17, 2016

LGTM

LK4D4 added a commit that referenced this pull request Feb 17, 2016
@LK4D4
Merge pull request #20187 from cyphar/vendor-runc
929f62e 
[carry 19752] vendor: update runc/libcontainer to v0.0.8
@LK4D4 LK4D4 merged commit 929f62e into moby:master Feb 17, 2016
This was referenced Feb 17, 2016
Closed
Merged
@cyphar cyphar deleted the vendor-runc branch February 17, 2016 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyphar @thaJeztah @LK4D4 @cpuguy83 @calavera @GordonTheTurtle