Skip to content

Add support for --cgroup:container:<id>#19244

Closed
mrunalp wants to merge 2 commits intomoby:masterfrom
mrunalp:cgroup_container
Closed

Add support for --cgroup:container:<id>#19244
mrunalp wants to merge 2 commits intomoby:masterfrom
mrunalp:cgroup_container

Conversation

@mrunalp
Copy link
Copy Markdown
Contributor

@mrunalp mrunalp commented Jan 11, 2016

Implements #18654

I am working on creating PRs for runc but have all the code in here right now to make it easier to test.

@jessfraz
Copy link
Copy Markdown
Contributor

ooo cool feature :)

@mrunalp
Copy link
Copy Markdown
Contributor Author

mrunalp commented Jan 11, 2016

@jfrazelle Thanks for the +1 :) I am working on rebasing this and the simple runc PR.

@icecrime
Copy link
Copy Markdown
Contributor

Ping @mrunalp! Should we close for now?

@mrunalp
Copy link
Copy Markdown
Contributor Author

mrunalp commented Jan 26, 2016

@icecrime I am waiting for a libcontaner bump. I will rebase the other changes and keep them ready.

@thaJeztah
Copy link
Copy Markdown
Member

ping @mrunalp #20187 was just merged and bumps runc

@icecrime
Copy link
Copy Markdown
Contributor

Ping @mrunalp! Thanks :-)

@icecrime icecrime added the status/failing-ci Indicates that the PR in its current state fails the test suite label Feb 29, 2016
@mrunalp
Copy link
Copy Markdown
Contributor Author

mrunalp commented Feb 29, 2016

I will update the PR this week.

Sent from my iPhone

On Feb 28, 2016, at 7:33 PM, Arnaud Porterie notifications@github.com wrote:

Ping @mrunalp! Thanks :-)


Reply to this email directly or view it on GitHub.

@thaJeztah
Copy link
Copy Markdown
Member

Thanks @mrunalp!

@mrunalp
Copy link
Copy Markdown
Contributor Author

mrunalp commented Mar 1, 2016

I have created docker-engine PR that is required for this docker-archive-public/docker.engine-api#119

mrunalp added 2 commits March 1, 2016 14:18
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@calavera
Copy link
Copy Markdown
Contributor

I think we should NOT move this forward before 1.11. That would mean that it needs to be handled when containerd integration is ready. Should we close it, since it will require to be rewritten? @tonistiigi ?

@thaJeztah
Copy link
Copy Markdown
Member

ping @mrunalp containerd is now integrated; were you planning on updating this PR, or do you want me to close this one and you opening a new one?

@mrunalp
Copy link
Copy Markdown
Contributor Author

mrunalp commented Mar 29, 2016

I can open a new PR. Thanks!

Sent from my iPhone

On Mar 28, 2016, at 7:23 PM, Sebastiaan van Stijn notifications@github.com wrote:

ping @mrunalp containerd is now integrated; were you planning on updating this PR, or do you want me to close this one and you opening a new one?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@thaJeztah
Copy link
Copy Markdown
Member

thanks, let me close this one then

@thaJeztah thaJeztah closed this Mar 29, 2016
@thaJeztah thaJeztah removed the status/failing-ci Indicates that the PR in its current state fails the test suite label May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants