Add support for --cgroup:container:<id>#19244
Conversation
|
ooo cool feature :) |
|
@jfrazelle Thanks for the +1 :) I am working on rebasing this and the simple runc PR. |
|
Ping @mrunalp! Should we close for now? |
|
@icecrime I am waiting for a libcontaner bump. I will rebase the other changes and keep them ready. |
|
Ping @mrunalp! Thanks :-) |
|
I will update the PR this week. Sent from my iPhone
|
|
Thanks @mrunalp! |
|
I have created docker-engine PR that is required for this docker-archive-public/docker.engine-api#119 |
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
6042850 to
ac50a13
Compare
|
I think we should NOT move this forward before 1.11. That would mean that it needs to be handled when containerd integration is ready. Should we close it, since it will require to be rewritten? @tonistiigi ? |
|
ping @mrunalp containerd is now integrated; were you planning on updating this PR, or do you want me to close this one and you opening a new one? |
|
I can open a new PR. Thanks! Sent from my iPhone
|
|
thanks, let me close this one then |
Implements #18654
I am working on creating PRs for runc but have all the code in here right now to make it easier to test.