Merged
Conversation
pkg/filenotify isn't used anymore and it causes problems with hack/vendor.sh (nothing uses it, so hack/vendor.sh will remove the vendored code). Signed-off-by: Aleksa Sarai <asarai@suse.com>
It is not longer used by us, so hack/vendor.sh complains because it removes unused files (but also complains about removing an entire vendored project). Signed-off-by: Aleksa Sarai <asarai@suse.com>
Member
|
since it's a package; do we know if other projects use this? (Not sure how that's usually handled?) Other than that, LGTM if we don't use it anymore 😄 |
Member
|
LGTM, if people are using it thy just need to check out the correct tag like any other package. |
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer use it, and it's causing vendor Jenkins jobs to fail.
Signed-off-by: Aleksa Sarai asarai@suse.com
/cc @cpuguy83 @LK4D4 @thaJeztah