MNT: Deprecate montage=[str, Montage, DigMontage] in readers.#6526
Closed
massich wants to merge 29 commits intomne-tools:masterfrom
Closed
MNT: Deprecate montage=[str, Montage, DigMontage] in readers.#6526massich wants to merge 29 commits intomne-tools:masterfrom
massich wants to merge 29 commits intomne-tools:masterfrom
Conversation
added 2 commits
July 3, 2019 14:09
Codecov Report
@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
- Coverage 89.31% 87.89% -1.42%
==========================================
Files 413 413
Lines 74562 74612 +50
Branches 12296 12300 +4
==========================================
- Hits 66592 65579 -1013
- Misses 5128 6196 +1068
+ Partials 2842 2837 -5 |
added 22 commits
July 3, 2019 15:28
update_ch_names needs to be driven from inside the reader.
Contributor
Author
|
Note, elements that are passed to kind in [sik db] montage::kind : /home/sik/mne_data/MNE-testing-data/EEGLAB/test_chans.locs
[sik db] montage::kind : /home/sik/mne_data/MNE-testing-data/EEGLAB/test_chans.locs
[sik db] montage::kind : /home/sik/mne_data/MNE-testing-data/EEGLAB/test_chans.locs
[sik db] montage::kind : /home/sik/mne_data/MNE-testing-data/EEGLAB/test_chans.locs
[sik db] montage::kind : /tmp/mne-XXXXX/mne/io/brainvision/tests/data/test.hpts
[sik db] montage::kind : /tmp/mne-XXXXX/mne/io/brainvision/tests/data/test.hpts
[sik db] montage::kind : /tmp/mne-XXXXX/mne/io/brainvision/tests/data/test.hpts
[sik db] montage::kind : /tmp/mne-XXXXX/mne/io/edf/tests/data/biosemi.hpts
[sik db] montage::kind : /tmp/mne-XXXXX/mne/io/edf/tests/data/biosemi.hpts
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.bvef
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.csd
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.elc
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.elp
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.hpts
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.sfp
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test.txt
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test_fid.hpts
[sik db] montage::kind : /tmp/tmp_mne_tempdir_rtu307nt/test_fid.sfp
[sik db] montage::kind : biosemi32
[sik db] montage::kind : biosemi32
[sik db] montage::kind : mgh60
[sik db] montage::kind : mgh70
[sik db] montage::kind : standard_1020 |
Contributor
Author
|
needs rebase after #6532 |
Contributor
Author
|
closing in favor of #6534. I'll be moving some parts, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we can just deprecate the montage in the readers, and allow the constructors for the moment.