MNT: Avoid non-parametrized testing inside parametrized test#6532
Merged
massich merged 6 commits intomne-tools:masterfrom Jul 5, 2019
Merged
MNT: Avoid non-parametrized testing inside parametrized test#6532massich merged 6 commits intomne-tools:masterfrom
massich merged 6 commits intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6532 +/- ##
==========================================
+ Coverage 89.31% 89.31% +<.01%
==========================================
Files 413 413
Lines 74562 74549 -13
Branches 12296 12294 -2
==========================================
- Hits 66592 66581 -11
+ Misses 5128 5127 -1
+ Partials 2842 2841 -1 |
Contributor
Author
|
That's all I would touch in here. Otherwise, #6526 would diverge too much. Hopefully, this should be green and no coverage lost. cc: @agramfort |
agramfort
approved these changes
Jul 5, 2019
Member
agramfort
left a comment
There was a problem hiding this comment.
I don't understand fully what you're doing but merge as soon as it's green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run some non-parametrized code several times just because the code
is inside a parametrized test