MNT, TST: clarify existing behavior of set_montage / __init__ montage#6529
Merged
larsoner merged 10 commits intomne-tools:masterfrom Jul 5, 2019
Merged
MNT, TST: clarify existing behavior of set_montage / __init__ montage#6529larsoner merged 10 commits intomne-tools:masterfrom
larsoner merged 10 commits intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6529 +/- ##
==========================================
- Coverage 89.31% 89.26% -0.05%
==========================================
Files 413 413
Lines 74532 74556 +24
Branches 12293 12297 +4
==========================================
- Hits 66565 66552 -13
- Misses 5126 5161 +35
- Partials 2841 2843 +2 |
added 2 commits
July 4, 2019 19:46
agramfort
reviewed
Jul 4, 2019
mne/io/eeglab/tests/test_eeglab.py
Outdated
| _assert_array_equal_nan(np.array([ch['loc'] for ch in foo.info['chs']]), | ||
| EXPECTED_LOCATIONS_FROM_MONTAGE) | ||
|
|
||
| # flushing |
mne/io/eeglab/tests/test_eeglab.py
Outdated
| def _assert_array_equal_nan(left, right): | ||
| # from mne.utils import _array_equal_nan | ||
| # assert _array_equal_nan(np.array([ch['loc'] for ch in raw.info['chs']]), | ||
| # EXPECTED_LOCATIONS_FROM_MONTAGE) |
Contributor
Author
|
I guess it can go in. But my main goal with this PR was to unfold the behavior of the set_montage. |
agramfort
approved these changes
Jul 5, 2019
massich
pushed a commit
to massich/mne-python
that referenced
this pull request
Jul 5, 2019
massich
pushed a commit
that referenced
this pull request
Jul 5, 2019
massich
pushed a commit
to massich/mne-python
that referenced
this pull request
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far this PR rewrites an existing test to discuss which is the desired behaviour