Skip to content

[MRG] Deprecate montage param from all EEG raw readers#6534

Merged
massich merged 9 commits intomne-tools:masterfrom
agramfort:deprecate_montage
Jul 10, 2019
Merged

[MRG] Deprecate montage param from all EEG raw readers#6534
massich merged 9 commits intomne-tools:masterfrom
agramfort:deprecate_montage

Conversation

@agramfort
Copy link
Copy Markdown
Member

@agramfort agramfort commented Jul 6, 2019

alternative to #6526

@agramfort
Copy link
Copy Markdown
Member Author

agramfort commented Jul 6, 2019

crap my master was behind :( :(

@massich I tried to the job with what i consider a dumb approach....

@agramfort agramfort force-pushed the deprecate_montage branch from a63c927 to 0530a7c Compare July 7, 2019 12:25
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2019 •
edited
Loading

Codecov Report

Merging #6534 into master will decrease coverage by <.01%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master    #6534      +/-   ##
==========================================
- Coverage   89.34%   89.33%   -0.01%     
==========================================
  Files         416      416              
  Lines       74865    74889      +24     
  Branches    12341    12344       +3     
==========================================
+ Hits        66885    66905      +20     
- Misses       5137     5138       +1     
- Partials     2843     2846       +3

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 7, 2019

This pull request introduces 1 alert when merging 05217a8 into 201ce50 - view on LGTM.com

new alerts:

  • 1 for Mismatch between signature and use of an overridden method

@agramfort agramfort changed the title [WIP] Deprecate montage param from all EEG raw readers [MRG] Deprecate montage param from all EEG raw readers Jul 8, 2019
@agramfort
Copy link
Copy Markdown
Member Author

agramfort commented Jul 8, 2019

we have the same error on master now https://travis-ci.org/mne-tools/mne-python/jobs/555779112

not sure about the circle failure though

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Jul 8, 2019 

/home/circleci/project/doc/whats_new.rst:75: WARNING: py:func reference target not found: mne.io.read_epochs_eeglab

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 8, 2019

This pull request introduces 1 alert when merging 53bf894 into 7d64af3 - view on LGTM.com

new alerts:

  • 1 for Mismatch between signature and use of an overridden method

@massich
Copy link
Copy Markdown
Contributor

massich commented Jul 8, 2019

This PR only deprecates that montage has to be None. It does not deprecate the montage parameter itself.

@massich massich mentioned this pull request Jul 8, 2019
Closed
@agramfort agramfort force-pushed the deprecate_montage branch from add1da1 to 92c1061 Compare July 10, 2019 08:46
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 10, 2019

This pull request introduces 1 alert when merging 92c1061 into 964ea6c - view on LGTM.com

new alerts:

  • 1 for Mismatch between signature and use of an overridden method

larsoner
larsoner reviewed Jul 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually in the messages we say explicitly when it will be removed, in this case 0.20. otherwise LGTM +1 for merge

@agramfort
Copy link
Copy Markdown
Member Author

agramfort commented Jul 10, 2019 via email

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 10, 2019

This pull request introduces 1 alert when merging 5ffe301 into 26231ff - view on LGTM.com

new alerts:

  • 1 for Mismatch between signature and use of an overridden method

@massich
Copy link
Copy Markdown
Contributor

massich commented Jul 10, 2019

+1, once travis is green I'll fix the whatsnew and merge it.

@massich massich mentioned this pull request Jul 10, 2019
Closed
19 tasks
@massich massich merged commit 8c9a3a8 into mne-tools:master Jul 10, 2019
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 10, 2019

This pull request introduces 1 alert when merging 56986b7 into 2b11463 - view on LGTM.com

new alerts:

  • 1 for Mismatch between signature and use of an overridden method

@massich
Copy link
Copy Markdown
Contributor

massich commented Jul 11, 2019

we should not be able to create info with montage shuold we?
https://github.com/mne-tools/mne-python/blob/master/mne/io/meas_info.py#L1586

@agramfort
Copy link
Copy Markdown
Member Author

agramfort commented Jul 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agramfort @larsoner @massich