Conversation
Codecov Report
@@ Coverage Diff @@
## master #6420 +/- ##
==========================================
+ Coverage 89.27% 89.28% +<.01%
==========================================
Files 411 411
Lines 74477 74551 +74
Branches 12312 12327 +15
==========================================
+ Hits 66487 66560 +73
- Misses 5133 5135 +2
+ Partials 2857 2856 -1 |
This comment has been minimized.
This comment has been minimized.
|
rendering of homepage: https://13557-1301584-gh.circle-artifacts.com/0/dev/index.html |
|
Thanks for adding my institution! Did you want to put the logos in three rows, where Inria is the only logo in the second row? If it is not possible to put them into one row anymore, I'd split them up into two rows. |
|
I agree. +1 for split them up into two rows.
|
It looks like a CSS class problem, probably. Maybe |
|
For me in Firefox with a maximized browser window all logos are on one line, and inria looks fine. I'll test with other browsers after breakfast :)
…On June 6, 2019 6:43:38 AM AKDT, Eric Larson ***@***.***> wrote:
> Did you want to put the logos in three rows, where Inria is the only
logo in the second row?
It looks like a CSS class problem, probably. Maybe `max-width` needs to
be set? For me in chrome dev tools if I add `width=100px` to the Inria
`img` I get two rows automatically, so the problem seems to be with
that particular image (probably the SVG itself) trying to be 100%
width.
|
|
Chrome:
|
|
switching Inria from SVG to PNG solved the weird issue with Inria being on its own line; not sure what that was all about. I also added some margins to the logos so they're not so crammed together. What I can't figure out how to do is prevent the (now taller) footer from overlaying the last bit of the page content... a |
|
actually, I think I got it. Will push a fix after confirming with a local re-build. |
|
FYI if the partial rebuilds are taking a while for you, you probably need numpy/numpydoc#226 |
larsoner
left a comment
There was a problem hiding this comment.
LGTM +1 for merge. Render:
https://13594-1301584-gh.circle-artifacts.com/0/dev/index.html
|
Thanks @drammock! |
|
Can we backport this so that the changes go live with 0.18.2? |
|
yes. Can you open PR to maint/0.18 branch?
… |
* add individual inst. logos; add uni-graz * add image titles (hover) * force add missing logos * codespell skip SVG files * fix: make inria PNG; better logo wrapping * fix footer overlap; slightly larger logos
|
Thanks @larsoner! |
* FIX: allow raw_fif to parse brainvision events (#6417) * TST: usecase * FIX: check annotation description base names * fix: remove pathlib * RFC: Alternative without getattr. * imports * Fix: avoid adding 'barinvision' as event_id keyword * remove _get_auto_event_id * update whatsnew * Update brainvision.py * cosmit * fix * use rstrip * MRG+1, DOC: footer logos (#6420) * add individual inst. logos; add uni-graz * add image titles (hover) * force add missing logos * codespell skip SVG files * fix: make inria PNG; better logo wrapping * fix footer overlap; slightly larger logos * STY: prefer _DefaultEventParser to _Counter (#6355) * Fix docstrings (#6385) * docstring deduplication * more n_jobs * fix: import fill_doc * fix crossrefs; deduplicate docdict def for random_state * FIX: Conftest [circle front] * FIX: Ref [circle front]
Looks good for me locally; hopefully same on CircleCI