MAINT: 0.18.2 backports#6449
Merged
agramfort merged 6 commits intomne-tools:maint/0.18from Jun 12, 2019
Merged
Conversation
* TST: usecase * FIX: check annotation description base names * fix: remove pathlib * RFC: Alternative without getattr. * imports * Fix: avoid adding 'barinvision' as event_id keyword * remove _get_auto_event_id * update whatsnew * Update brainvision.py * cosmit * fix * use rstrip
* add individual inst. logos; add uni-graz * add image titles (hover) * force add missing logos * codespell skip SVG files * fix: make inria PNG; better logo wrapping * fix footer overlap; slightly larger logos
* docstring deduplication * more n_jobs * fix: import fill_doc * fix crossrefs; deduplicate docdict def for random_state
Codecov Report
@@ Coverage Diff @@
## maint/0.18 #6449 +/- ##
==============================================
+ Coverage 89.24% 89.25% +<.01%
==============================================
Files 418 418
Lines 75501 75535 +34
Branches 12431 12433 +2
==============================================
+ Hits 67384 67419 +35
Misses 5231 5231
+ Partials 2886 2885 -1 |
Member
|
thx a lot @larsoner can you take care of pushing to pypi? |
Contributor
|
If there is still time, it'd be great if you also included #6429 (then I could immediately use this in MNELAB). |
Member
|
please open PRs asap before we push in pypi
|
Contributor
|
Never mind, I can't figure out how to quickly pick the relevant commits and rebase only these onto |
Contributor
|
OK, I figured it out: #6450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
__init__.pyTests pass locally, but will iterate until CIs are happy then merge.
Then maybe we cut 0.18.2?