Skip to content

MRG, MAINT: remove matplotlib version pin#6426

Merged
massich merged 3 commits intomne-tools:masterfrom
larsoner:3.1
Jun 6, 2019
Merged

MRG, MAINT: remove matplotlib version pin#6426
massich merged 3 commits intomne-tools:masterfrom
larsoner:3.1

Conversation

@larsoner
Copy link
Copy Markdown
Member

@larsoner larsoner commented Jun 6, 2019

Closes #6424.

Not sure why this was needed, @massich feel free to chime in. In the meantime maybe the CIs will tell us.

@larsoner larsoner force-pushed the 3.1 branch 2 times, most recently from b403e7d to a6e5eff Compare June 6, 2019 17:06
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 6, 2019

This pull request introduces 1 alert when merging 0ae5d20 into c2b9176 - view on LGTM.com

new alerts:

  • 1 for Unused import

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2019

Codecov Report

Merging #6426 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6426      +/-   ##
==========================================
+ Coverage    89.1%   89.27%   +0.17%     
==========================================
  Files         411      411              
  Lines       74519    74518       -1     
  Branches    12318    12317       -1     
==========================================
+ Hits        66399    66526     +127     
+ Misses       5243     5134     -109     
+ Partials     2877     2858      -19

@massich massich changed the title MRG, MAINT: Remove mpl req MRG, MAINT: remove matplotlib version pin Jun 6, 2019
@massich massich merged commit 3652287 into mne-tools:master Jun 6, 2019
@larsoner larsoner deleted the 3.1 branch June 6, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why do we have matplotlib < 3.1 in requirements.txt?

2 participants