Merged
Conversation
|
Can confirm this solves the re-build of scikit-learn! |
jnothman
approved these changes
Jun 20, 2019
Collaborator
Author
|
I'll merge tomorrow unless there are objections |
jnothman
approved these changes
Jun 22, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that my Sphinx was always doing a full rebuild. It's because with
xrefwe modify the config to add some values after the builder is initted. But then this env gets pickled and saved to disk, so on the next sphinx build run it compares the user's config (which does not have these values) to the pickled config (which has the added values) which triggers a full rebuild every time.This fixes it by instead just checking our set after the user's set when doing the
xrefstep. It's a tiny bit less efficient but should not be too much of a slowdown.