Fix vmax slider for EvokedField figures#12354
Merged
drammock merged 3 commits intomne-tools:mainfrom Jan 16, 2024
Merged
Conversation
Contributor
Author
|
I'm not sure we need a deprecation cycle for the |
larsoner
reviewed
Jan 12, 2024
Member
larsoner
left a comment
There was a problem hiding this comment.
Can you add a doc/changes/bugfix.rst to document the fix? (Or a doc/changes/12354.bugfix.rst if you don't want the bot to auto-rename it using your PR number?)
Otherwise LGTM
drammock
approved these changes
Jan 12, 2024
Contributor
Author
|
I don't think the CI failure is related to this PR? |
Member
those errors are gone from our code after #12353; but it looks like pyvista code is triggering them. I'll push a quick ignore-fix |
Member
|
actually not so easy to ignore, as they're errors, not warnings. I've opened pyvista/pyvista#5472. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes bugs introduced by shadowing the build-in
typeobject. When adding unit tests, more bugs surfaced and were fixed.fixes #12352