Skip to content

BUG: flake in code due to shadowing of builtin #12352

@larsoner

Description

@larsoner

@wmvanvliet EvokedField._on_colormap_range has a comparison if type == "meg", but type here is the builtin type rather than something passed by kwarg for example:

if type == "meg":

When you get a chance can you fix this?

Bonus points for removing these shadowing of builtins, it's a reason we generally prefer stuff like type_ to type when not use the builtin -- the flake / ruff check would have caught this issue then!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions