MAINT: Check and format with NPY201#12353
Merged
drammock merged 3 commits intomne-tools:mainfrom Jan 11, 2024
Merged
Conversation
larsoner
commented
Jan 11, 2024
Comment on lines
+476
to
+478
| # TODO: type is undefined here and only avoids a flake warning because it's | ||
| # a builtin! | ||
| if type == "meg": # noqa: E721 |
drammock
approved these changes
Jan 11, 2024
Member
|
thanks @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the NumPy 2.0 migration guide they mentioned that there is a new ruff rule NPY201, so let's go ahead and enable it. It caught some
==where we should have usedisin a few places. It also false-alarms on stuff likeif x.dtype == float, which we shouldn't change toif x.dtype is floatbecauseisdoes not give the behavior we want:so this PR just uses the explicit
if x.dtype == np.dtype(float)in those cases.