BUG: Fix where report replacement did not respect section #11346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/main: Revert "[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI" (mne-tools#11350) [ENH] Add tutorial on time-frequency source estimation with STC viewer GUI (mne-tools#10920) FIX: Fix example (mne-tools#11348) Add mastodon link (mne-tools#11347) fix default n_fft for spectrum plots (mne-tools#11345)
Member
Author
|
@drammock this is ready for review/merge from my end, I think the M1 failure is unrelated / timeout (I restarted it but I don't think we need to wait) |
drammock
approved these changes
Dec 6, 2022
Member
drammock
left a comment
There was a problem hiding this comment.
LGTM and tests pass, so +1 for merge after clarifying the confusing comment (see below).
larsoner
added a commit
to britta-wstnr/mne-python
that referenced
this pull request
Dec 8, 2022
* upstream/main: ENH: Add webp support to Report (mne-tools#11359) ENH: More complete report repr (mne-tools#11357) MAINT: Simplify server installation instructions (mne-tools#11356) BUG: Fix where report replacement did not respect section (mne-tools#11346) [DOC] Fix video link for coregistration (mne-tools#11354)
larsoner
added a commit
to ealtamir/mne-python
that referenced
this pull request
Dec 8, 2022
* upstream/main: ENH: Add webp support to Report (mne-tools#11359) ENH: More complete report repr (mne-tools#11357) MAINT: Simplify server installation instructions (mne-tools#11356) BUG: Fix where report replacement did not respect section (mne-tools#11346) [DOC] Fix video link for coregistration (mne-tools#11354) Revert "[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI" (mne-tools#11350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with mne-tools/mne-bids-pipeline#669, otherwise you can only have one evoked plot at a time because they are nested by condition as section, and the
titles are all the same when using.add_section(e.g.,Time course (EEG)is the title but the section isCondition: Auditorywould replace a plot fromCondition: Visualif it exists already)!