-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MAINT: Update server environment #11356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hoechenberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's hope it goes green
|
A "fun" little rabbit hole -- conflict is between vtk 9.2 and OpenMEEG 2.5.5. Looks like the former uses HDF5 1.12.2 and the latter only built with 1.12.1... which forces use of VTK 9.1, which has no proper osmesa version (or it's not as easy to use). If conda-forge/openmeeg-feedstock#40 works I'll merge, then in a couple of hours test locally that things work, then push a commit here. We should see VTK 9.2.2 in all conda-forge builds after this rather than 9.1, which will be nice. |
|
Okay I think we can't just use our built-in file because Qt causes an abort when we try to instantiate it: we could maybe try to detect this but it seems fragile. The same problem will occur if people accidentally try to use mne-qt-browser or matplotlib with the Qt backend, etc. The simplest solution seems to be to keep the separate |
|
... @hoechenberger for your docker instance, though, another option would be to use |
|
Okay I tried adding some infrastructure for detecting bad Qt and notebook setups, hopefully this makes the NB run pass, and we can indeed delete the |
|
Seems to be working, @drammock feel free to mark for merge if you're happy with this approach |
|
Yay! @drammock i had automerge activated, please feel free to revert if you're not happy with this PR! |
* upstream/main: ENH: Add webp support to Report (mne-tools#11359) ENH: More complete report repr (mne-tools#11357) MAINT: Simplify server installation instructions (mne-tools#11356) BUG: Fix where report replacement did not respect section (mne-tools#11346) [DOC] Fix video link for coregistration (mne-tools#11354)
* upstream/main: ENH: Add webp support to Report (mne-tools#11359) ENH: More complete report repr (mne-tools#11357) MAINT: Simplify server installation instructions (mne-tools#11356) BUG: Fix where report replacement did not respect section (mne-tools#11346) [DOC] Fix video link for coregistration (mne-tools#11354) Revert "[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI" (mne-tools#11350)
Closes #11355
Let's see if it works