fix default n_fft for spectrum plots #11345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Minimal failure looks real |
Member
Author
all better. |
agramfort
approved these changes
Dec 1, 2022
cbrnr
approved these changes
Dec 1, 2022
Member
|
Thanks @drammock! |
Member
drammock
added a commit
that referenced
this pull request
Dec 1, 2022
Member
Author
Member
|
@drammock can you cut a minor release? Hopefully the last before 1.3, which we should push out in the next couple of weeks ideally |
Member
Author
|
Will do tomorrow, out sick rest of today
-------- Original Message --------
…On Dec 1, 2022, 10:49, Eric Larson wrote:
***@***.***(https://github.com/drammock) can you cut a minor release? Hopefully the last before 1.3, which we should push out in the next couple of weeks ideally
—
Reply to this email directly, [view it on GitHub](#11345 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAN2AUZXE7FHCD37CGC4ZM3WLDJKTANCNFSM6AAAAAASP5LEC4).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
drammock
added a commit
that referenced
this pull request
Dec 2, 2022
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Dec 6, 2022
* upstream/main: Revert "[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI" (mne-tools#11350) [ENH] Add tutorial on time-frequency source estimation with STC viewer GUI (mne-tools#10920) FIX: Fix example (mne-tools#11348) Add mastodon link (mne-tools#11347) fix default n_fft for spectrum plots (mne-tools#11345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11343
there was already code in there to use the old default
n_fftin hopes of avoiding this bug, but that code wasn't getting triggered in some cases because it looked formethod=='welch'and was receivingmethod=='auto'. Now we convert "auto" to a proper method name right away.