FIX: Flake #10540
Merged
FIX: Flake #10540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
approved these changes
Apr 18, 2022
Member
|
@larsoner I'd love to merge this PR but apparently with the new restrictions, I don't have sufficient permissions as the Qt test was not passing. Could you please either relax this requirement, or give me elevated permissions, or can we maybe re-think this entire thing? As it is now, I'm feeling a bit "debilitated", which I'm sure was not the intention :) |
agramfort
approved these changes
Apr 18, 2022
Member
|
thx @larsoner |
Member
Author
Agreed, it seems to be causing more harm than good. I never saw a "merge once all checks pass" anyway, I only ever saw the admin-level "merge now ignoring requirements". I've removed the requirements for now |
Member
|
Thanks Eric! |
larsoner
added a commit
to wmvanvliet/mne-python
that referenced
this pull request
Apr 19, 2022
* upstream/main: (40 commits) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) MAINT: Prefer PySide6 in testing (mne-tools#10513) ENH: Add overview_mode support (mne-tools#10501) MRG: Updates for qtpy in mne-qt-browser (mne-tools#10509) BUG: Fix bug with themes on macOS (mne-tools#10500) MAINT: Bump installer links (mne-tools#10511) Add metadata to combine_channels (mne-tools#10504) MAINT: Standardize tests (mne-tools#10502) CI: Test circle (mne-tools#10506) ENH: Use HiDPI splash screen on HiDPI screens (mne-tools#10503) WIP,MNT: Add support for QtPy (mne-tools#10430) ...
larsoner
added a commit
to jona-sassenhagen/mne-python
that referenced
this pull request
Apr 19, 2022
* upstream/main: MRG: Add "verbose" parameter to pick_channels() method (mne-tools#10544) CI: Avoid bad PySide6 (mne-tools#10545) FIX: Flake (mne-tools#10540)
larsoner
added a commit
to agramfort/mne-python
that referenced
this pull request
Apr 21, 2022
* upstream/main: (52 commits) MAINT: Extra test for coreg (mne-tools#10549) BUG: Fix annot meas_date / crop (mne-tools#10491) Update latest.inc Use liblinear solver instead of lbgfs in all decodung examples [skip azp][skip actions] (mne-tools#10552) STY: Hotfix for HTML [ci skip] Allow making inverse solutions from fixed-orientation discrete forward models, enabling multi-dipole modeling (mne-tools#10464) Correct documented default number of CV splits [skip azp][skip actions] (mne-tools#10548) MRG: Add error checking to prevent the creation of montage with invalid [x, y, z] (mne-tools#10547) MRG: Add "verbose" parameter to pick_channels() method (mne-tools#10544) CI: Avoid bad PySide6 (mne-tools#10545) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.