MAINT: Prefer PySide6 in testing #10513
Conversation
|
Argh, I meant for that to be the text for the mne-qt-browser PR I'm about to open. This PR might require a 0.3.0 release, we'll see! |
|
PySide6's wheel does not work on 18.04 LTS, and switching to 20.04 LTS we get volume rendering bugs from MESA
I'll try PyQt6 on CircleCI + Ubuntu 18.04. That might be a way forward at least... |
dfb39dc to
81d2428
Compare
|
Okay this one is good to go. We still use PyQt5 on CircleCI because PySide6 uses too new an ABI for 18.04, and we can't move away from 18.04 until https://gitlab.freedesktop.org/mesa/mesa/-/issues/6309 is sorted out |
|
Now the problem with PySide6 on CircleCI is a remaining reference: I'll take care of that in a separate PR, though. Ready for review/merge from my end! |
|
Okay locally I was able to get PySide6 working by making appropriate use of @hoechenberger I addressed the comments above, so I'll merge if it does indeed come back green. |
There was a problem hiding this comment.
LGTM! Thanks @larsoner, feel free to merge once green
* upstream/main: (40 commits) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) MAINT: Prefer PySide6 in testing (mne-tools#10513) ENH: Add overview_mode support (mne-tools#10501) MRG: Updates for qtpy in mne-qt-browser (mne-tools#10509) BUG: Fix bug with themes on macOS (mne-tools#10500) MAINT: Bump installer links (mne-tools#10511) Add metadata to combine_channels (mne-tools#10504) MAINT: Standardize tests (mne-tools#10502) CI: Test circle (mne-tools#10506) ENH: Use HiDPI splash screen on HiDPI screens (mne-tools#10503) WIP,MNT: Add support for QtPy (mne-tools#10430) ...
I think we should cut a release. Given that this will be the first to support Qt6, I bumped to 0.3.0 (last release was 0.2.6).@agramfort or @hoechenberger feel free to merge and I'll cut a releaseUses PySide6 as our preferred framework in testing. We can't change
environment.ymluntil conda-forge manages to release PySide6, which will require Qt6 first. So it might be a while!Todo