FIX : read fids in eeglab #10521
FIX : read fids in eeglab #10521
Conversation
84b42dc to
3df07e3
Compare
|
SphinxWindows failure is unrelated |
hoechenberger
left a comment
There was a problem hiding this comment.
nitpick, otherwise LGTM!
| assert pos['nasion'] is not None | ||
| assert pos['lpa'] is not None | ||
| assert pos['rpa'] is not None |
There was a problem hiding this comment.
Should we maybe check whether the arrays have the correct dimension too?
|
Is the coreg failure related? (I don't think so?) |
|
Thanks @agramfort |
|
You guys are so fast. I only got the chance to test the PR today. I confirm that reading the fids works now for our SET file. 👍 However, I do not see them being written again in the SET file when saving the data again and opening them in EEGLAB. If I reopen the new file with read_raw_eeglab, I can confirm that the fids are not there either. @agramfort should I open a different issue for that? |
Sure, that's an exporting rather than reading bug. Or you can reopen your old issue an re-title it to discuss round-trip failing. (Now the read works, but the write doesn't.) |
|
See #10529 for the new issue. I linked the old issue in the description as well. |
|
we don't have a strong support for exporting. Why do you need to write it
back to eeglab format?
Message ID: ***@***.***>
… |
|
We need to create a BIDS structure with the SET file after anonymization of other fields in order to share data with others. |
|
Couldn't EEGLAB's BIDS export be an option for you, then? |
|
Not really unfortunately as it requires a Matlab license... |
|
And if you try our BrainVision export? Would that maybe help? Maybe it works better :) |
|
our collaborator wants SET files... We have no other choice than to have the mne export functionality to work with SET files. Sorry |
|
@cmadjar you need to report this issue here https://github.com/jackz314/eeglabio/issues we use this code to export |
|
ok. Done! |
* upstream/main: (40 commits) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) MAINT: Prefer PySide6 in testing (mne-tools#10513) ENH: Add overview_mode support (mne-tools#10501) MRG: Updates for qtpy in mne-qt-browser (mne-tools#10509) BUG: Fix bug with themes on macOS (mne-tools#10500) MAINT: Bump installer links (mne-tools#10511) Add metadata to combine_channels (mne-tools#10504) MAINT: Standardize tests (mne-tools#10502) CI: Test circle (mne-tools#10506) ENH: Use HiDPI splash screen on HiDPI screens (mne-tools#10503) WIP,MNT: Add support for QtPy (mne-tools#10430) ...
* upstream/main: (52 commits) MAINT: Extra test for coreg (mne-tools#10549) BUG: Fix annot meas_date / crop (mne-tools#10491) Update latest.inc Use liblinear solver instead of lbgfs in all decodung examples [skip azp][skip actions] (mne-tools#10552) STY: Hotfix for HTML [ci skip] Allow making inverse solutions from fixed-orientation discrete forward models, enabling multi-dipole modeling (mne-tools#10464) Correct documented default number of CV splits [skip azp][skip actions] (mne-tools#10548) MRG: Add error checking to prevent the creation of montage with invalid [x, y, z] (mne-tools#10547) MRG: Add "verbose" parameter to pick_channels() method (mne-tools#10544) CI: Avoid bad PySide6 (mne-tools#10545) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) ...
closes #10474
@cmadjar this should fix your problem.