[clockutils] Fix x64-windows-static-md#23965
Conversation
|
AFAICT |
|
I took the time to check upstream. |
This is more of an opinion. The practice is that if a port - especially if the repo wasn't updated for 5 years - to use |
Yes, this is my opinion. Of course there are also arguments:
IMO this is more another opinion than common practice. The differentiated version schemes don't exist for a long time. And very often,
If we don't expect a new version, we could just stay with |
This is what I want as well, but GH Actions doesn't like it. |
Yes, but the GH action didn't propose a change, it just failed with an error. Other port authors already went through version scheme ping-pong because of this. My initial comment was meant to save you from this pointless exercise. |
Cf. #24011 (comment) |
strega-nil-ms
left a comment
There was a problem hiding this comment.
I am very strongly of the opinion that this should be "version": "1.1.1" - this is clearly just 1.1.1 with a change from Alex, an old vcpkg maintainer.
|
Thanks! |
* master: (139 commits) [dstorage] Add port for Microsoft.Direct3D.DirectStorage NuGet (microsoft#24063) [vcpkg] Refactor toolchain & generator selection (microsoft#23846) [icu] update to 70.1 (microsoft#23445) [vcpkg] Update android usage documentation (microsoft#23690) [LMDB] update to 0.9.29 (microsoft#24045) [catch2] Don't install docs (microsoft#24046) [harfbuff] fix arm64 osx build (microsoft#24055) [openxr-loader] remove from CI baseline (microsoft#24057) [imath] Update to 3.1.5 (microsoft#24059) [openssl] Fix dynamic builds on UNIX (microsoft#24061) [c-ares] update to 1.18.1 (microsoft#24062) [igraph] update to 0.9.8 (microsoft#24065) [cmake-user] Fix library check (microsoft#24070) [openxr-loader] fix ci.baseline.txt (microsoft#24073) [tinycbor] Fix file conflicts with libcbor (microsoft#24056) [graphviz,libslirp] Limit msys to windows (microsoft#24032) [bdwgc] Don't build docs (microsoft#24025) [capstone] update to 5.0.0-rc2 (microsoft#23979) [clockutils] Fix x64-windows-static-md (microsoft#23965) [braft] New port (microsoft#23830) ...

Describe the pull request
What does your PR fix?
Note: still using
version-stringbecause of appended commit idWhich triplets are supported/not supported? Have you updated the CI baseline?
Removed from CI baseline; all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes