Skip to content

[icu] update to 70.1#23445

Merged
strega-nil-ms merged 12 commits intomicrosoft:masterfrom
FrankXie05:dev/Frank/22914
Apr 11, 2022
Merged

[icu] update to 70.1#23445
strega-nil-ms merged 12 commits intomicrosoft:masterfrom
FrankXie05:dev/Frank/22914

Conversation

@FrankXie05
Copy link
Copy Markdown
Contributor

Fix #22914

Update [icu] to the latest version 70.1

Note: no feature need to test

@FrankXie05 FrankXie05 added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Mar 9, 2022
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d72783cb3aeddfd667861caef1060e54ca6fa7a9 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/i-/icu.json b/versions/i-/icu.json
index a5b3860..58fd002 100644
--- a/versions/i-/icu.json
+++ b/versions/i-/icu.json
@@ -1,10 +1,15 @@
 {
   "versions": [
     {
-      "git-tree": "61cd63ec740b0a7e4de70baa4a343661ade3dbec",
+      "git-tree": "815b609f22fb5a0f0ba17c94242eb553a50d0134",
       "version": "70.1",
       "port-version": 0
     },
+    {
+      "git-tree": "5d1bac4d5b2a05af577b0aa5bb8f600e5cf15427",
+      "version": "69.1",
+      "port-version": 19
+    },
     {
       "git-tree": "789755812260e6c4759e305d1591938513023c07",
       "version": "69.1",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout d72783cb3aeddfd667861caef1060e54ca6fa7a9 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/i-/icu.json b/versions/i-/icu.json
index 58fd002..b1df4c4 100644
--- a/versions/i-/icu.json
+++ b/versions/i-/icu.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "815b609f22fb5a0f0ba17c94242eb553a50d0134",
+      "git-tree": "d2662a1ecdaff0fc3964f70bdb04305d3914334d",
       "version": "70.1",
       "port-version": 0
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/icu/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05 FrankXie05 marked this pull request as ready for review April 11, 2022 01:51
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 11, 2022
@strega-nil-ms
Copy link
Copy Markdown
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit e9fcbfe into microsoft:master Apr 11, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Apr 12, 2022
* master: (139 commits)
  [dstorage] Add port for Microsoft.Direct3D.DirectStorage NuGet (microsoft#24063)
  [vcpkg] Refactor toolchain & generator selection (microsoft#23846)
  [icu] update to 70.1 (microsoft#23445)
  [vcpkg] Update android usage documentation (microsoft#23690)
  [LMDB] update to 0.9.29 (microsoft#24045)
  [catch2] Don't install docs (microsoft#24046)
  [harfbuff] fix arm64 osx build (microsoft#24055)
  [openxr-loader] remove from CI baseline (microsoft#24057)
  [imath] Update to 3.1.5 (microsoft#24059)
  [openssl] Fix dynamic builds on UNIX (microsoft#24061)
  [c-ares] update to 1.18.1 (microsoft#24062)
  [igraph] update to 0.9.8 (microsoft#24065)
  [cmake-user] Fix library check (microsoft#24070)
  [openxr-loader] fix ci.baseline.txt (microsoft#24073)
  [tinycbor] Fix file conflicts with libcbor (microsoft#24056)
  [graphviz,libslirp] Limit msys to windows (microsoft#24032)
  [bdwgc] Don't build docs (microsoft#24025)
  [capstone] update to 5.0.0-rc2 (microsoft#23979)
  [clockutils] Fix x64-windows-static-md (microsoft#23965)
  [braft] New port (microsoft#23830)
  ...
@daschuer
Copy link
Copy Markdown
Contributor

daschuer commented May 2, 2022

The build is failing now on MacOS and Linux:

configure: WARNING: unrecognized options: --disable-silent-rules
./../src/c-70_1-src-a6ee276eef.clean/source/configure: line 8650: syntax error near unexpected token `newline'
./../src/c-70_1-src-a6ee276eef.clean/source/configure: line 8650: `AX_CHECK_COMPILE_FLAG('

@daschuer
Copy link
Copy Markdown
Contributor

daschuer commented May 2, 2022

Here a workaround is described:
#24140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[icu] update to 70.1

5 participants