Skip to content

[vcpkg] Update android usage documentation#23690

Merged
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
zhangfuwen:master
Apr 11, 2022
Merged

[vcpkg] Update android usage documentation#23690
strega-nil-ms merged 3 commits intomicrosoft:masterfrom
zhangfuwen:master

Conversation

@zhangfuwen
Copy link
Copy Markdown
Contributor

@zhangfuwen zhangfuwen commented Mar 21, 2022

Doc update by deleting triplet creation step for android. The metioned triplets are already commited on master branch. There is no need to create triplet files for android. This doc is kind of outdated. I tried without the triplet creation step and jsoncpp installation is successful.

Describe the pull request

  • What does your PR fix?

    update doc by deleting android triplet creation step.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

NA.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

The metioned triplets are already commited on master branch. There is no need to create triplet files for android. This doc is kind of outdated. I tried without the triplet creation stelp and jsoncpp installation is successful.
@ghost
Copy link
Copy Markdown

ghost commented Mar 21, 2022

CLA assistant check
All CLA requirements met.

@BillyONeal BillyONeal changed the title Master Update android usage documentation Mar 21, 2022
@JonLiu1993 JonLiu1993 added the category:documentation To resolve the issue, documentation will need to be updated label Mar 22, 2022
@JonLiu1993
Copy link
Copy Markdown
Contributor

@zhangfuwen ,Thanks for your pr, could you please sign in CLA first?

@zhangfuwen
Copy link
Copy Markdown
Contributor Author

@zhangfuwen ,Thanks for your pr, could you please sign in CLA first?

done, sorry for late response.

@JonLiu1993
Copy link
Copy Markdown
Contributor

Could you please merge the branch to master? thanks!

@JonLiu1993 JonLiu1993 changed the title Update android usage documentation [vcpkg] Update android usage documentation Apr 2, 2022
@zhangfuwen
Copy link
Copy Markdown
Contributor Author

Could you please merge the branch to master? thanks!

Is message to me or someone else? I don't quite get it. What do you want me to do?

@JackBoosY
Copy link
Copy Markdown
Contributor

@zhangfuwen Yeah, it's to you. Please merge to master.

Thanks.

@zhangfuwen
Copy link
Copy Markdown
Contributor Author

zhangfuwen commented Apr 6, 2022

@zhangfuwen Yeah, it's to you. Please merge to master.

Thanks.

@JonLiu1993 sorry, how should I do it?

@JonLiu1993
Copy link
Copy Markdown
Contributor

@zhangfuwen Yeah, it's to you. Please merge to master.
Thanks.

@JonLiu1993 sorry, how should I do it?

Done

@JackBoosY
Copy link
Copy Markdown
Contributor

cc @dg0yt @luncliff @pthom for review this changes.

@JackBoosY
Copy link
Copy Markdown
Contributor

I'll keep this PR open for a week until no one has any objections.

Copy link
Copy Markdown
Contributor

@luncliff luncliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 11, 2022
@strega-nil-ms
Copy link
Copy Markdown
Contributor

Thanks @zhangfuwen :)

@strega-nil-ms strega-nil-ms merged commit 97298f2 into microsoft:master Apr 11, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Apr 12, 2022
* master: (139 commits)
  [dstorage] Add port for Microsoft.Direct3D.DirectStorage NuGet (microsoft#24063)
  [vcpkg] Refactor toolchain & generator selection (microsoft#23846)
  [icu] update to 70.1 (microsoft#23445)
  [vcpkg] Update android usage documentation (microsoft#23690)
  [LMDB] update to 0.9.29 (microsoft#24045)
  [catch2] Don't install docs (microsoft#24046)
  [harfbuff] fix arm64 osx build (microsoft#24055)
  [openxr-loader] remove from CI baseline (microsoft#24057)
  [imath] Update to 3.1.5 (microsoft#24059)
  [openssl] Fix dynamic builds on UNIX (microsoft#24061)
  [c-ares] update to 1.18.1 (microsoft#24062)
  [igraph] update to 0.9.8 (microsoft#24065)
  [cmake-user] Fix library check (microsoft#24070)
  [openxr-loader] fix ci.baseline.txt (microsoft#24073)
  [tinycbor] Fix file conflicts with libcbor (microsoft#24056)
  [graphviz,libslirp] Limit msys to windows (microsoft#24032)
  [bdwgc] Don't build docs (microsoft#24025)
  [capstone] update to 5.0.0-rc2 (microsoft#23979)
  [clockutils] Fix x64-windows-static-md (microsoft#23965)
  [braft] New port (microsoft#23830)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:documentation To resolve the issue, documentation will need to be updated info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants