.Net MEVD: More Conformance tests#10944
Merged
adamsitnik merged 1 commit intomicrosoft:mainfrom Mar 13, 2025
Merged
Conversation
- introduce CollectionConformanceTests - make GenerateNextKey thread-safe - make sure the tests don't create collection if there is no need to - implement the tests for Postgres, SQL Server and Redis (partially)
shethaadit
approved these changes
Mar 12, 2025
This was referenced Mar 13, 2025
westey-m
previously approved these changes
Mar 13, 2025
dmytrostruk
previously approved these changes
Mar 13, 2025
The base branch was changed.
westey-m
approved these changes
Mar 13, 2025
dmytrostruk
approved these changes
Mar 13, 2025
roji
approved these changes
Mar 13, 2025
Member
roji
left a comment
There was a problem hiding this comment.
Super happy to see this, awesome work @adamsitnik.
I still personally much rather read test names like Delete_collection_does_not_throw_for_non_existing_collection than DeleteCollectionDoesNotThrowForNonExistingCollection (after all that's why we have spaces in human language ;)). That's the test naming convention we use in EF and it works really well where test names start to get long.
dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/Support/SimpleModelFixture.cs
Show resolved
Hide resolved
dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/Models/SimpleModel.cs
Show resolved
Hide resolved
roji
reviewed
Mar 13, 2025
dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/Support/VectorStoreFixture.cs
Show resolved
Hide resolved
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
- introduce CollectionConformanceTests - introduce RecordConformanceTests - make GenerateNextKey thread-safe - make sure the tests don't create collection if there is no need to - implement the tests for Postgres, SQL Server and Redis (partially) contributes to microsoft#10194 and microsoft#10882 and microsoft#10883
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…oft#10952) It's a resurrected microsoft#10788 built on top of microsoft#10944 which I hope will get merged first. fixes microsoft#10415 --------- Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contributes to #10194 and #10882 and #10883