.Net MEVD: Port the Pinecone connector to use Pinecone.Client#10952
Merged
adamsitnik merged 12 commits intomicrosoft:mainfrom Mar 20, 2025
Merged
.Net MEVD: Port the Pinecone connector to use Pinecone.Client#10952adamsitnik merged 12 commits intomicrosoft:mainfrom
adamsitnik merged 12 commits intomicrosoft:mainfrom
Conversation
westey-m
reviewed
Mar 13, 2025
dotnet/src/Connectors/Connectors.Memory.Pinecone/PineconeVectorStoreRecordCollection.cs
Show resolved
Hide resolved
westey-m
reviewed
Mar 13, 2025
.../src/IntegrationTests/Connectors/Memory/Pinecone/PineconeVectorStoreRecordCollectionTests.cs
Show resolved
Hide resolved
…re it's compliant with Conformance tests
- throw when the user provides IndexKind - fix the build - restore the tests that test code paths not covered by the "new" tests
6ef2f64 to
699fdee
Compare
westey-m
reviewed
Mar 19, 2025
dotnet/src/Connectors/Connectors.Memory.Pinecone/PineconeVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
…by Pinecone to give clear error messages right away
…ing tests to cover Skip and Top
…rStoreRecordCollection.cs Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
westey-m
approved these changes
Mar 19, 2025
...t/src/VectorDataIntegrationTests/PineconeIntegrationTests/Filter/PineconeBasicFilterTests.cs
Outdated
Show resolved
Hide resolved
...t/src/VectorDataIntegrationTests/PineconeIntegrationTests/Filter/PineconeBasicFilterTests.cs
Outdated
Show resolved
Hide resolved
...t/src/VectorDataIntegrationTests/PineconeIntegrationTests/Filter/PineconeBasicFilterTests.cs
Outdated
Show resolved
Hide resolved
...Tests/VectorDataIntegrationTests/VectorSearch/VectorSearchDistanceFunctionComplianceTests.cs
Show resolved
Hide resolved
Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
westey-m
approved these changes
Mar 19, 2025
roji
approved these changes
Mar 20, 2025
…that I can't reproduce locally
westey-m
approved these changes
Mar 20, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…oft#10952) It's a resurrected microsoft#10788 built on top of microsoft#10944 which I hope will get merged first. fixes microsoft#10415 --------- Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a resurrected #10788 built on top of #10944 which I hope will get merged first.
fixes #10415