Skip to content

Add Tooltip support#701

Merged
chiuam merged 33 commits intomicrosoft:masterfrom
chiuam:tooltip
Jan 29, 2021
Merged

Add Tooltip support#701
chiuam merged 33 commits intomicrosoft:masterfrom
chiuam:tooltip

Conversation

@chiuam
Copy link
Copy Markdown

@chiuam chiuam commented Jan 28, 2021 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This change adds tooltip support for the following components:

  1. Button
  2. Text
  3. Image
  4. Slider
  5. TextInput

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

image

Microsoft Reviewers: Open in CodeFlow

alloy and others added 27 commits January 27, 2021 20:01
@alloy @chiuam
[package] Bump to currently published v0.62.1
03992b7
@rnbot @chiuam
Applying package update to 0.62.2 ***NO_CI***
85acf4c
@rnbot @chiuam
Applying package update to 0.62.3 ***NO_CI***
033d97a
@rnbot @chiuam
Applying package update to 0.62.4 ***NO_CI***
b34fadc
@rnbot @chiuam
Applying package update to 0.62.5 ***NO_CI***
3c22002
@rnbot @chiuam
Applying package update to 0.62.6 ***NO_CI***
164d73b
@rnbot @chiuam
Applying package update to 0.62.7 ***NO_CI***
e4e3c0f
@rnbot @chiuam
Applying package update to 0.62.8 ***NO_CI***
c94519b
@rnbot @chiuam
Applying package update to 0.62.9 ***NO_CI***
843ccf0
@rnbot @chiuam
Applying package update to 0.62.10 ***NO_CI***
ae16d6e
@rnbot @chiuam
Applying package update to 0.62.11 ***NO_CI***
c6420e7
@rnbot @chiuam
Applying package update to 0.62.12 ***NO_CI***
c5047ce
@rnbot @chiuam
Applying package update to 0.62.13 ***NO_CI***
ba43807
@rnbot @chiuam
Applying package update to 0.62.14 ***NO_CI***
9b31500
@rnbot @chiuam
Applying package update to 0.62.15 ***NO_CI***
469597a
@rnbot @chiuam
Applying package update to 0.62.16 ***NO_CI***
be9bd9b
@rnbot @chiuam
Applying package update to 0.62.17 ***NO_CI***
34672cb
@rnbot @chiuam
Applying package update to 0.62.18 ***NO_CI***
761c701
@rnbot @chiuam
Applying package update to 0.62.19 ***NO_CI***
d4737a7
@rnbot @chiuam
Applying package update to 0.62.20 ***NO_CI***
71f6447
@rnbot @chiuam
Applying package update to 0.62.21 ***NO_CI***
0be3b60
@mganandraj @chiuam
Ensuring that the same version of folly is built as well as packaged (m…
2467163 
…icrosoft#690)
@rnbot @chiuam
Applying package update to 0.62.22 ***NO_CI***
b7fc708
@chiuam
Add tooltip support
2c967a8
@chiuam
add tooltip support for <Image>
b48cee5
@chiuam
add test case for <View>
2fd7d42
@chiuam
fix merge changes
039ef82
@chiuam chiuam requested a review from alloy as a code owner January 28, 2021 18:22
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 28, 2021 •
edited
Loading

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 6e53a76

@HeyImChris
Copy link
Copy Markdown

HeyImChris commented Jan 28, 2021

Are there any other controls that might need this? For instance macOS sliders have a tooltip to represent the % it's set to. Checkboxes also have tooltips and so can TextInputs on macOS. If we can easily enough get them all up and running that'd probably save us some time in the future

@chiuam
Copy link
Copy Markdown
Author

chiuam commented Jan 28, 2021

Are there any other controls that might need this? For instance macOS sliders have a tooltip to represent the % it's set to. Checkboxes also have tooltips and so can TextInputs on macOS. If we can easily enough get them all up and running that'd probably save us some time in the future

Sure, I added tooltip support to slider and text input. I think Checkbox has been removed from React Native and has a community module for it now - https://github.com/react-native-community/react-native-checkbox

@HeyImChris
Copy link
Copy Markdown

HeyImChris commented Jan 29, 2021

Run yarn flow-check-ios and you'll see a couple JS issues that'll need to get fixed up. Once that command is all green then it should be good to checkin.

@HeyImChris
Copy link
Copy Markdown

HeyImChris commented Jan 29, 2021

I tried cloning your branch and making this change myself but I don't have permissions to push to your fork (probably a good thing :)). You'll want to add onPress={() => {}} on line 63 in Button.js under tooltip={"Button tooltip"} for the CI errors to go away- then we can check in!

@chiuam chiuam merged commit 3089291 into microsoft:master Jan 29, 2021
HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Feb 5, 2021
@chiuam @HeyImChris
Add Tooltip support (microsoft#701)
7a157f3
HeyImChris added a commit that referenced this pull request Feb 9, 2021
@HeyImChris @chiuam
Cherry pick tooltip support to 0.63 branch (#713)
f26243a 
* Add nullability checks (#704)

* Update RCTCxxBridge.mm

* add nullability checks

* 63 tooltips

* Add Tooltip support (#701)

Co-authored-by: chiuam <67026167+chiuam@users.noreply.github.com>
chiuam added a commit to chiuam/react-native-macos that referenced this pull request May 26, 2021
@chiuam
Add Tooltip support (microsoft#701)
149568e
@chiuam chiuam mentioned this pull request May 26, 2021
Merged
4 tasks
HeyImChris pushed a commit that referenced this pull request May 28, 2021
@chiuam
Add Tooltip support (#701) (#783)
4ae25ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alloy alloy Awaiting requested review from alloy

1 more reviewer

@HeyImChris HeyImChris HeyImChris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chiuam @pull-bot @HeyImChris @alloy @rnbot @mganandraj