Skip to content

Cherry pick tooltip support to 0.63 branch#713

Merged
HeyImChris merged 4 commits intomicrosoft:0.63-stablefrom
HeyImChris:63tooltip
Feb 9, 2021
Merged

Cherry pick tooltip support to 0.63 branch#713
HeyImChris merged 4 commits intomicrosoft:0.63-stablefrom
HeyImChris:63tooltip

Conversation

@HeyImChris
Copy link
Copy Markdown

@HeyImChris HeyImChris commented Feb 5, 2021 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This change was checked in to master with commit 308929130e426730a6cd0818c95a4cbf68a0bcc7. Moving it to 0.63 so downstream stable dependencies can leverage it.

git cherry-pick 308929130e426730a6cd0818c95a4cbf68a0bcc7

Microsoft Reviewers: Open in CodeFlow

@HeyImChris HeyImChris self-assigned this Feb 5, 2021
@HeyImChris HeyImChris requested a review from alloy as a code owner February 5, 2021 18:43
@harrieshin
Copy link
Copy Markdown

harrieshin commented Feb 5, 2021

that's weird. I thought Amanda made multiple file changes... cherry picked wrong?

@chiuam
Copy link
Copy Markdown

chiuam commented Feb 5, 2021

that's weird. I thought Amanda made multiple file changes... cherry picked wrong?

+1. The changes I made to the components for adding the tooltip prop.

@HeyImChris
Copy link
Copy Markdown
Author

HeyImChris commented Feb 5, 2021

that's weird. I thought Amanda made multiple file changes... cherry picked wrong?

+1. The changes I made to the components for adding the tooltip prop.

Whoops yea something went wrong with the cherry pick. Let me try again

@HeyImChris HeyImChris merged commit f26243a into microsoft:0.63-stable Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@harrieshin harrieshin harrieshin approved these changes

@alloy alloy Awaiting requested review from alloy

+1 more reviewer

@chiuam chiuam chiuam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChris HeyImChris

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HeyImChris @harrieshin @chiuam @Saadnajmi