Skip to content

Ensuring that the same version of folly is built as well as packaged#690

Merged
acoates-ms merged 1 commit intomicrosoft:0.62-stablefrom
mganandraj:RN62FollyFix
Jan 16, 2021
Merged

Ensuring that the same version of folly is built as well as packaged#690
acoates-ms merged 1 commit intomicrosoft:0.62-stablefrom
mganandraj:RN62FollyFix

Conversation

@mganandraj
Copy link
Copy Markdown

@mganandraj mganandraj commented Jan 16, 2021 •
edited by ghost
Loading

This commit (b2afdfd#diff-8cc88adda4da183aafc286681a96e285509fd92919e0549a163c376f2ee12994) has updated the Android publish task to build with downloaded folly sources. But, the changes to package the downloaded folly headers is not yet available in RN62-stable. Which resulted in ABI mismatch when consuming the RN62 nuget package.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Devmain SDX features are crashing due to ABI mismatches when using Folly datastructures.

Changelog

Devmain SDX features are crashing due to ABI mismatches when using Folly datastructures.

This commit (b2afdfd#diff-8cc88adda4da183aafc286681a96e285509fd92919e0549a163c376f2ee12994) has updated the Android publish task to build with downloaded folly sources. But, the changes to package the downloaded folly headers is not yet available in RN62-stable. Which resulted in ABI mismatch when consuming the RN62 nuget package.

[CATEGORY] [TYPE] - Message

Test Plan

Devmain applications shouldn't crash

Microsoft Reviewers: Open in CodeFlow

@mganandraj mganandraj requested a review from tom-un as a code owner January 16, 2021 01:11
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 16, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 0fcddbd

@acoates-ms acoates-ms merged commit d9a8312 into microsoft:0.62-stable Jan 16, 2021
chiuam pushed a commit to chiuam/react-native-macos that referenced this pull request Jan 28, 2021
@mganandraj @chiuam
Ensuring that the same version of folly is built as well as packaged (m…
2467163 
…icrosoft#690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@tom-un tom-un Awaiting requested review from tom-un tom-un is a code owner

@HeyImChris HeyImChris Awaiting requested review from HeyImChris

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mganandraj @pull-bot @acoates-ms