Update Master with latest dev branch by cheenamalhotra · Pull Request #555 · microsoft/mssql-jdbc

cheenamalhotra · 2017-11-17T17:53:58Z

No description provided.

Running a query that uses a timer can cause an IllegalThreadStateException if the underlying ThreadGroup has been destroyed

Forgot to add AtomicReference

Replace manual array copying with System.arraycopy().

Calling toString() on a String object is redundant

Replace bare literals with magic constants. For example: `cal.set(1, 1, 577738, 0, 0, 0);` becomes `cal.set(1, Calendar.FEBRUARY, 577738, 0, 0, 0);`

This reverts commit e77a046.

… columns"" This reverts commit 8f69956.

Updated docker image tag for mssql-server-linux

Updating docker run command as well.

…eanupTables

Cleaning up tables

…L Server 2008/2012 and throw Exception

…nd adding a test case for this

Remove redundant String.toString()

updates gradle dependencies

revise the way that pom file uses version number

… fix for BatchTriggerTest

…ching is disabled on the connection

…otherwise throw sql server exception

Fix for static logger member in abstract class 'SQLServerClobBase'

Throw exception for "Account Locked" SQL Exception 18486

Fix prepared statement metadata cache issue

Update Changelog for 6.3.5 Release

codecov-io · 2017-11-17T21:31:45Z

Codecov Report

Merging #555 into master will decrease coverage by <.01%.
The diff coverage is 78.94%.

@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
- Coverage     46.71%   46.71%   -0.01%     
+ Complexity     2227     2224       -3     
============================================
  Files           108      108              
  Lines         25308    25321      +13     
  Branches       4175     4175              
============================================
+ Hits          11823    11828       +5     
- Misses        11457    11472      +15     
+ Partials       2028     2021       -7

Flag	Coverage Δ	Complexity Δ
#JDBC41	`46.51% <78.94%> (+0.02%)`	`2210 <19> (-8)`	⬇️
#JDBC42	`46.6% <78.94%> (-0.04%)`	`2222 <19> (-1)`

Impacted Files	Coverage Δ	Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerException.java	`76.85% <ø> (ø)`	`29 <0> (ø)`	⬇️
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...a/com/microsoft/sqlserver/jdbc/SQLServerNClob.java	`100% <100%> (ø)`	`3 <2> (-1)`	⬇️
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java	`15.1% <100%> (+0.44%)`	`14 <0> (ø)`	⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	`45.75% <50%> (-0.23%)`	`277 <2> (ø)`
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java	`27.94% <75%> (-0.32%)`	`3 <2> (-1)`
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	`51.24% <80.88%> (-0.33%)`	`159 <10> (-5)`
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java	`59.65% <83.33%> (+0.18%)`	`133 <3> (+2)`	⬆️
...ooglecode/concurrentlinkedhashmap/LinkedDeque.java	`28.46% <0%> (-3.08%)`	`20% <0%> (-2%)`
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java	`39.39% <0%> (-2.82%)`	`44% <0%> (-2%)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a76c7...91e7d8a. Read the comment docs.

Fixed minor issue that came during conflict resolution

mnhubspot and others added 30 commits September 1, 2017 16:50

TimeoutTimer: Check for destroyed TheadGroup

4213afc

Running a query that uses a timer can cause an IllegalThreadStateException if the underlying ThreadGroup has been destroyed

TimeoutTimer: Forgot reference

9da95c5

Forgot to add AtomicReference

recognize CallableStatement parameter names with leading '@'

6789eb6

Replace manual array copy

0b410f0

Replace manual array copying with System.arraycopy().

Remove redundant String.toString()

16bd589

Calling toString() on a String object is redundant

Replace bare literals

d94cccc

Replace bare literals with magic constants. For example: `cal.set(1, 1, 577738, 0, 0, 0);` becomes `cal.set(1, Calendar.FEBRUARY, 577738, 0, 0, 0);`

cleanup tables after test

6f262f8

more cleaning of tables and procedures

328feec

Implement checkDuplicateColumnName to check duplicate columns

e77a046

Revert "Implement checkDuplicateColumnName to check duplicate columns"

8f69956

This reverts commit e77a046.

Revert "Revert "Implement checkDuplicateColumnName to check duplicate…

f8e89df

… columns"" This reverts commit 8f69956.

Apply same logic for TVP

91a3eea

use try with resources

fe83139

add another try-with-resource

7f18810

drop a not needed method

d778a6f

try-with-resources implementation commit 1

ada51de

Update .travis.yml

5b2657c

Updated docker image tag for mssql-server-linux

Update .travis.yml

7efd39f

Updating docker run command as well.

Fix AESetup issue with dropCEK

052b4b5

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into cl…

a94cb96

…eanupTables

try-with-resources implementation commit 2

5ef8dea

Merge branch 'dev' into JavaImprovements

889f160

avoid creating connection for termination

55641c8

remove null check and change Set object name

8c0ebf2

Merge pull request #509 from v-afrafi/cleanupTables

b00b377

Cleaning up tables

tweak to preserve original parameter name for exception message

e2ec02e

Check for "Account Locked" SQL Exception 18486 while connecitng to SQ…

d4eadd6

…L Server 2008/2012 and throw Exception

Updated comment for Locked User Account in SQLServerConnection.java

4a1409a

Refactoring the logic for checking duplicate column into Util class a…

adf10ea

…nd adding a test case for this

Merge pull request #501 from JamieMagee/redundant-String-toString

e5f7c6c

Remove redundant String.toString()

xiangyushawn and others added 25 commits October 24, 2017 13:36

Merge pull request #526 from newnewcoder/dev

f52e6c7

updates gradle dependencies

revise the way that pom file uses version number

5693c39

add -preview

c231b11

Merge pull request #535 from v-xiangs/xiangs-update-POM-file

5c75147

revise the way that pom file uses version number

Fix for static logger member in abstract class 'SQLServerClobBase'

93e0b18

fix handle not fund bug for metadata caching

5940cfc

fix tests

97a5cfc

fix failures in requesthandling test

9ffd521

remove prepStmtHandle = -1 which disables metadata caching, and added…

2cbd065

… fix for BatchTriggerTest

remove fix for BatchTriggerTest, it breaks PreparedStatementTest

ab68580

fix hasPreparedStatementHandle()

5c74751

add the fix for batch trigger

9a54b6b

fix "handle is not valid" error. If context changed once, metadata ca…

705ebc1

…ching is disabled on the connection

clear cached prepared statement handle when pooled connection is removed

3ccdf0f

merge the fix of batch trigger

8559a33

change back the test to catch BatchUpdateException exception

1839edc

disable metadata caching after switching database on connection directly

875f62a

process all batch first, then throw batch exception is there is one, …

df89f02

…otherwise throw sql server exception

Merge pull request #537 from cheenamalhotra/staticLoggerQuery

4be9856

Fix for static logger member in abstract class 'SQLServerClobBase'

Merge pull request #522 from cheenamalhotra/throwAccountLockedEx

be14e88

Throw exception for "Account Locked" SQL Exception 18486

re-enable metadata caching after context change

1992eed

Merge pull request #543 from v-xiangs/fix-metadata-cache-2

7e1f663

Fix prepared statement metadata cache issue

Updated Changelog for 6.3.5 Release

8d6d446

Merge pull request #554 from cheenamalhotra/dev

8f15e20

Update Changelog for 6.3.5 Release

Merge branch 'master' into dev

62227e3

Update pom.xml

91e7d8a

Fixed minor issue that came during conflict resolution

cheenamalhotra requested a review from AfsanehR-zz November 20, 2017 18:42

AfsanehR-zz approved these changes Nov 21, 2017

View reviewed changes

cheenamalhotra merged commit 9f0b214 into master Nov 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Master with latest dev branch#555

Update Master with latest dev branch#555
cheenamalhotra merged 68 commits intomasterfrom
dev

cheenamalhotra commented Nov 17, 2017

Uh oh!

codecov-io commented Nov 17, 2017 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

cheenamalhotra commented Nov 17, 2017

Uh oh!

codecov-io commented Nov 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecov-io commented Nov 17, 2017 •

edited

Loading