Skip to content

revise the way that pom file uses version number#535

Merged
xiangyushawn merged 2 commits intomicrosoft:devfrom
xiangyushawn:xiangs-update-POM-file
Oct 27, 2017
Merged

revise the way that pom file uses version number#535
xiangyushawn merged 2 commits intomicrosoft:devfrom
xiangyushawn:xiangs-update-POM-file

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Oct 27, 2017 •
edited
Loading

with the updated pom file,
mvn install -Pbuild41 builds jar, source.jar, javadoc.jar as version x.x.x.jre7-xxxxx
mvn install -Pbuild42 builds jar, source.jar, javadoc.jar as version x.x.x.jre8-xxxxx

no longer needs to change version manually for maven releases

@xiangyushawn xiangyushawn requested a review from ulvii October 27, 2017 01:10
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 27, 2017 •
edited
Loading

Codecov Report

Merging #535 into dev will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #535      +/-   ##
============================================
+ Coverage     46.46%   46.61%   +0.15%     
- Complexity     2213     2224      +11     
============================================
  Files           107      108       +1     
  Lines         25304    25308       +4     
  Branches       4175     4175              
============================================
+ Hits          11758    11798      +40     
+ Misses        11512    11481      -31     
+ Partials       2034     2029       -5
Flag Coverage Δ Complexity Δ
#JDBC41 46.4% <ø> (-0.06%) 2211 <ø> (-2)
#JDBC42 46.49% <ø> (?) 2221 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.46% <0%> (-0.46%) 104% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.39% <0%> (-0.04%) 0% <0%> (ø)
.../com/microsoft/sqlserver/jdbc/SQLServerJdbc42.java 25% <0%> (ø) 0% <0%> (?)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (+0.1%) 130% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.98% <0%> (+0.15%) 277% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.1% <0%> (+0.16%) 244% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.44% <0%> (+0.21%) 63% <0%> (+1%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (+0.21%) 46% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.11% <0%> (+0.24%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.77% <0%> (+0.31%) 240% <0%> (+1%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f52e6c7...c231b11. Read the comment docs.

@xiangyushawn xiangyushawn merged commit 5c75147 into microsoft:dev Oct 27, 2017
@xiangyushawn xiangyushawn deleted the xiangs-update-POM-file branch October 27, 2017 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ulvii ulvii ulvii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiangyushawn @codecov-io @ulvii @lilgreenbird