Skip to content

Remove redundant String.toString()#501

Merged
AfsanehR-zz merged 1 commit intomicrosoft:devfrom
JamieMagee:redundant-String-toString
Oct 7, 2017
Merged

Remove redundant String.toString()#501
AfsanehR-zz merged 1 commit intomicrosoft:devfrom
JamieMagee:redundant-String-toString

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

@JamieMagee JamieMagee commented Sep 22, 2017

Calling toString() on a String object is redundant

@JamieMagee
Remove redundant String.toString()
16bd589 
Calling toString() on a String object is redundant
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 22, 2017

Codecov Report

Merging #501 into dev will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #501      +/-   ##
============================================
- Coverage     46.64%   46.56%   -0.08%     
  Complexity     2218     2218              
============================================
  Files           108      108              
  Lines         25279    25279              
  Branches       4167     4167              
============================================
- Hits          11791    11772      -19     
- Misses        11463    11484      +21     
+ Partials       2025     2023       -2
Flag Coverage Δ Complexity Δ
#JDBC41 46.36% <50%> (-0.04%) 2209 <0> (+4)
#JDBC42 46.38% <50%> (-0.09%) 2208 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.58% <0%> (-0.7%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.32% <100%> (-0.39%) 238 <0> (-1)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.01% <50%> (ø) 277 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.15% <0%> (-1.29%) 63% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.43% <0%> (-1.09%) 88% <0%> (-2%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.32% <0%> (-0.25%) 165% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (+0.3%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.37% <0%> (+0.4%) 244% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dfd49...16bd589. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 22, 2017 •
edited
Loading

Codecov Report

Merging #501 into dev will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #501      +/-   ##
============================================
- Coverage     46.64%   46.56%   -0.08%     
  Complexity     2218     2218              
============================================
  Files           108      108              
  Lines         25279    25279              
  Branches       4167     4167              
============================================
- Hits          11791    11772      -19     
- Misses        11463    11484      +21     
+ Partials       2025     2023       -2
Flag Coverage Δ Complexity Δ
#JDBC41 46.36% <50%> (-0.04%) 2209 <0> (+4)
#JDBC42 46.38% <50%> (-0.09%) 2208 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.58% <0%> (-0.7%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.32% <100%> (-0.39%) 238 <0> (-1)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.01% <50%> (ø) 277 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 61.15% <0%> (-1.29%) 63% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.43% <0%> (-1.09%) 88% <0%> (-2%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.32% <0%> (-0.25%) 165% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (+0.3%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.37% <0%> (+0.4%) 244% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dfd49...16bd589. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 6.3.4 milestone Sep 26, 2017
@AfsanehR-zz AfsanehR-zz merged commit e5f7c6c into microsoft:dev Oct 7, 2017
@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Oct 7, 2017

Thank you @JamieMagee for your effort in creating this pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@AfsanehR-zz AfsanehR-zz AfsanehR-zz approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@JamieMagee @codecov-io @AfsanehR-zz @peterbae @lilgreenbird @msftclas @msftgits @cheenamalhotra