Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #509 +/- ##
===========================================
- Coverage 46.54% 46.45% -0.1%
+ Complexity 2216 2214 -2
===========================================
Files 108 108
Lines 25312 25312
Branches 4181 4181
===========================================
- Hits 11781 11758 -23
- Misses 11497 11527 +30
+ Partials 2034 2027 -7
Continue to review full report at Codecov.
|
| rs = callableStatement.executeQuery(); | ||
| rs.close(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Before closing the try, terminate variation can be passed existing Connection & Statement objects instead of starting a new connection for dropping objects.
cheenamalhotra
requested changes
Oct 5, 2017
Member
cheenamalhotra
left a comment
There was a problem hiding this comment.
With the minor change requested, implementation looks good!
cheenamalhotra
approved these changes
Oct 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.