fix(instructions): update broken file directives and markdown links after collection directory reorg#743
Conversation
…nks after collection directory reorg
- update relative paths from ../instructions/ to ../../instructions/{collection}/
- fix references in 6 ADO prompt/agent files
- fix references in 6 GitHub prompt files and 1 agent file
- fix references in 3 HVE-Core prompt files
🔗 - Generated by Copilot
Co-authored-by: katriendg <838216+katriendg@users.noreply.github.com>
|
Looking good. |
Updated the PR description using For the PR title, please rename it to: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
katriendg
left a comment
There was a problem hiding this comment.
Looks very good, but will ask for additional reviewer besides me (as the originator)
## Pre-Release 3.1.44 ### ✨ Features - add Docusaurus 3 documentation site with GitHub Pages deployment (#680) - add workflow permissions validation for OpenSSF Scorecard compliance (#759) - add DT coach return path handoff to task-researcher (#591) (#758) - add DT subagent handoff workflow instructions (#592) (#757) - create dt-method-06-deep.instructions.md (#602) (#748) - create dt-method-05-deep.instructions.md (#747) - add DT-aware task-implementor context instructions (#755) - extract embedded PowerShell from workflows into testable scripts (#738) - add gitleaks binary-based secret scanning as PR gate (#734) - add SBOM generation, attestation, and diff tooling to release pipeline (#730) - add dt-learning-tutor agent for DT education (#662) - add DT image prompt generation guidance for Method 5 (#726) - add DT-aware task-reviewer review context (#714) - add dt-method-next routing prompt (#713) - create dt-method-04-deep.instructions.md (#709) - add Implementation Space exit handoff prompt for DT workflows (#708) - add Write-CIStepSummary markdown table to Test-SHAStaleness github output (#660) - add dt-handoff-solution-space prompt for Solution Spac… (#707) ### 🐛 Bug Fixes - update sidebar link color to meet WCAG AA contrast requirements (#814) - harden even/odd versioning against regression and syntax errors (#816) - replace even/odd versioning with SemVer -rc.N suffixes (#811) - ensure prerelease label exists before PR creation (#806) - replace Docusaurus favicons with Microsoft logo (#808) - add missing subagents and shared instructions to collection manifests (#804) - standardize file path conventions for copilot-tracking output (#784) - enforce project-scoped artifact isolation across DT files (#766) - add top-level permissions to copilot-setup-steps.yml (#760) - update broken file directives and markdown links after collection directory reorg (#743) - add pre-release companion pipeline with even/odd versioning (#735) - exclude auto-generated CHANGELOG.md from spell check (#756) - add job-level permissions to extension-publish.yml (#729) - resolve handoff dependencies using display names (#727) - add job-level permissions to validate-version in extension-publish-prerelease (#731) - replace parent-directory VS Code settings paths with per-subdirectory enumeration (#732) ### 📚 Documentation - add Design Thinking documentation and DT-to-RPI handoff (#789) - add customization guides for HVE Core artifacts (#772) - reconcile documentation against implementation (#771) - document accepted Token-Permissions risks and add lint:dependency-pinning (#763) - add Design Thinking section to hve-core-all collection description (#762) ### ♻️ Refactoring - move collection scripts from plugins to collections (#728) - remove duplicate git diff logic in frontmatter validator (#473) ### 🔧 Maintenance - bump basic-ftp from 5.0.5 to 5.2.0 (#780) - standardize script path references in SKILL.md files (#768) - bump the github-actions group across 1 directory with 2 updates (#752) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
## Pre-Release 3.1.46 ### ✨ Features - add Docusaurus 3 documentation site with GitHub Pages deployment (#680) - add workflow permissions validation for OpenSSF Scorecard compliance (#759) - add DT coach return path handoff to task-researcher (#591) (#758) - add DT subagent handoff workflow instructions (#592) (#757) - create dt-method-06-deep.instructions.md (#602) (#748) - create dt-method-05-deep.instructions.md (#747) - add DT-aware task-implementor context instructions (#755) - extract embedded PowerShell from workflows into testable scripts (#738) - add gitleaks binary-based secret scanning as PR gate (#734) - add SBOM generation, attestation, and diff tooling to release pipeline (#730) - add dt-learning-tutor agent for DT education (#662) - add DT image prompt generation guidance for Method 5 (#726) - add DT-aware task-reviewer review context (#714) - add dt-method-next routing prompt (#713) - create dt-method-04-deep.instructions.md (#709) - add Implementation Space exit handoff prompt for DT workflows (#708) - add Write-CIStepSummary markdown table to Test-SHAStaleness github output (#660) - add dt-handoff-solution-space prompt for Solution Spac… (#707) ### 🐛 Bug Fixes - update prerelease publish to use even/odd convention (#822) - update sidebar link color to meet WCAG AA contrast requirements (#814) - harden even/odd versioning against regression and syntax errors (#816) - replace even/odd versioning with SemVer -rc.N suffixes (#811) - ensure prerelease label exists before PR creation (#806) - replace Docusaurus favicons with Microsoft logo (#808) - add missing subagents and shared instructions to collection manifests (#804) - standardize file path conventions for copilot-tracking output (#784) - enforce project-scoped artifact isolation across DT files (#766) - add top-level permissions to copilot-setup-steps.yml (#760) - update broken file directives and markdown links after collection directory reorg (#743) - add pre-release companion pipeline with even/odd versioning (#735) - exclude auto-generated CHANGELOG.md from spell check (#756) - add job-level permissions to extension-publish.yml (#729) - resolve handoff dependencies using display names (#727) - add job-level permissions to validate-version in extension-publish-prerelease (#731) - replace parent-directory VS Code settings paths with per-subdirectory enumeration (#732) ### 📚 Documentation - add Design Thinking documentation and DT-to-RPI handoff (#789) - add customization guides for HVE Core artifacts (#772) - reconcile documentation against implementation (#771) - document accepted Token-Permissions risks and add lint:dependency-pinning (#763) - add Design Thinking section to hve-core-all collection description (#762) ### ♻️ Refactoring - move collection scripts from plugins to collections (#728) - remove duplicate git diff logic in frontmatter validator (#473) ### 🔧 Maintenance - pre-release 3.1.44 (#819) - bump basic-ftp from 5.0.5 to 5.2.0 (#780) - standardize script path references in SKILL.md files (#768) - bump the github-actions group across 1 directory with 2 updates (#752) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
Fixed 34 broken
#file:directives and markdown links across 15 files that were not updated during the collection-based directory reorganization (#643). All references followed the same pattern: using one../traversal when two are now required, and omitting the collection subdirectory name.Fix pattern applied:
#file:../instructions/{filename}.md→#file:../../instructions/{collection}/{filename}.md[text](../instructions/{filename}.md)→[text](../../instructions/{collection}/{filename}.md)Files updated (15 across 3 collections):
Type of Change
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Testing
npm run lint:allpasses with 0 errorsnpm run plugin:generatesucceedsnpm run spell-checkpasses with 0 issuesnpm run lint:md-links— only pre-existing external URL timeouts (microsoft.com domains), no failures from changed filesChecklist
Required Checks
Required Automated Checks
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-links(pre-existing external URL timeouts only)npm run lint:psnpm run plugin:generateSecurity Considerations
Additional Notes
This is an invisible-to-end-users fix for the VS Code extension distribution, where broken
#file:directives prevent Copilot from resolving instruction files at runtime. The fix is a mechanical path correction with no behavioral changes.Original prompt
This section details on the original issue you should resolve
<issue_title>fix: Broken #file: directives and markdown links after collection directory reorg</issue_title>
<issue_description>## Summary
The collection-based directory reorganization (#643) moved agents, prompts, and instructions from flat directories into
{collection}/subdirectories. However, 34#file:directives and markdown links across 15 files were not updated to reflect the new directory depth. All broken references follow the same pattern: they use one../traversal when two are now required, and they omit the collection subdirectory name.Root Cause
Before the reorg, files were structured as:
A reference
#file:../instructions/github-backlog-triage.instructions.mdfrom a prompt correctly resolved to.github/instructions/github-backlog-triage.instructions.md.After the reorg:
The same reference
#file:../instructions/github-backlog-triage.instructions.mdnow resolves to.github/prompts/instructions/github-backlog-triage.instructions.md, which does not exist.Fix Pattern
Broken References
ADO Collection (7 references in 2 files)
.github/agents/ado/ado-prd-to-wit.agent.md#file:../instructions/ado-wit-planning.instructions.md#file:../../instructions/ado/ado-wit-planning.instructions.md.github/prompts/ado/ado-get-build-info.prompt.md#file:../instructions/ado-get-build-info.instructions.md#file:../../instructions/ado/ado-get-build-info.instructions.md.github/prompts/ado/ado-create-pull-request.prompt.md#file:../instructions/ado-create-pull-request.instructions.md#file:../../instructions/ado/ado-create-pull-request.instructions.md.github/prompts/ado/ado-process-my-work-items-for-task-planning.prompt.md#file:../instructions/ado-wit-planning.instructions.md#file:../../instructions/ado/ado-wit-planning.instructions.md.github/prompts/ado/ado-update-wit-items.prompt.md#file:../instructions/ado-update-wit-items.instructions.md#file:../../instructions/ado/ado-update-wit-items.instructions.md.github/prompts/ado/ado-get-my-work-items.prompt.md#file:../instructions/ado-wit-planning.instructions.md#file:../../instructions/ado/ado-wit-planning.instructions.mdGitHub Collection (19 references in 6 files)
.github/agents/github/github-backlog-manager.agent.md[...](../instructions/github-backlog-planning.instructions.md)[...](../../instructions/github/github-backlog-planning.instructions.md).github/agents/github/github-backlog-manager.agent.md[...](../instructions/github-backlog-planning.instructions.md)(×4)[...](../../instructions/github/github-backlog-planning.instructions.md).github/agents/github/github-backlog-manager.agent.md[...](../instructions/github-backlog-triage.instructions.md)[...](../../instructions/github/github-backlog-triage.instructions.md).github/agents/github/github-backlog-manager.agent.md[...](../instructions/github-backlog-discovery.instructions.md)[...](../../instructions/github/github-backlog-discovery.instructions.md).github/agents/github/github-backlog-manager.agent.md[...](../instructions/github-backlog-update.instructions.md)(×2)[...](../../instructions/github/github-backlog-update.instructions.md).github/prompts/github/github-triage-issues.prompt.md#file:../instructions/github-backlog-triage.instructions.md#file:../../instructions/github/github-backlog-triage.instructions.md.github/prompts/github/github-triage-issues.prompt.md#file:../instructions/github-backlog-planning.instructions.md#file:../../instructions/github/github-backlog-planning.instructions.md.github/prompts/github/github-add-issue.prompt.md#file:../instructions/github-backlog-planning.instructions.md#file:../../instructions/github/github-backlog-planning.instructions.md.github/prompts/github/github-discover-issues.prompt.md#file:../instructions/github-backlog-discovery.instructions.md#file:../../instructions/github/github-backlog-discovery.instructions.md.github/prompts/github/github-discover-issues.prompt.md🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.