Skip to content

feat(agents): Functional Code Review Agent — pre-PR functional correctness reviewer#733

Merged
WilliamBerryiii merged 13 commits intomicrosoft:mainfrom
seekdavidlee:feat/646-functional-code-review-agent
Mar 2, 2026
Merged

feat(agents): Functional Code Review Agent — pre-PR functional correctness reviewer#733
WilliamBerryiii merged 13 commits intomicrosoft:mainfrom
seekdavidlee:feat/646-functional-code-review-agent

Conversation

@seekdavidlee
Copy link
Copy Markdown
Contributor

@seekdavidlee seekdavidlee commented Feb 22, 2026

Pull Request

Description

Pre-PR branch diff reviewer for functional correctness, error handling, edge cases, and testing gaps

Related Issue(s)

Closes #646

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Script/automation (.ps1, .sh, .py)
  • Other (please describe):

Sample Prompts (for AI Artifact Contributions)

User Request:

Pls code review

Execution Flow:

Output Artifacts:

---
title: "Functional Code Review: first-time-login-error"
description: "Pre-PR functional code review for first-time-login-error against origin/main"
ms.date: 2026-02-22
branch: first-time-login-error
base: origin/main
total_issues: 2
severity_counts:
  critical: 1
  high: 0
  medium: 1
  low: 0
---

# Functional Code Review: `first-time-login-error` → `origin/main`

## Executive Summary

| Metric | Value |
|---|---|
| Files changed | 3 |
| Lines added | 41 |
| Lines removed | 59 |
| Critical issues | 1 |
| High issues | 0 |
| Medium issues | 1 |
| Low issues | 0 |

## Changed Files Overview

| File | Lines Changed | Risk Level | Issues Found |
|---|---|---|---|
| `Eklee.KeyVault.UI/src/auth/useAuthToken.ts` | –36 (deleted) | Low | 0 |
| `Eklee.KeyVault.UI/src/main.tsx` | +22 / –12 | High | 0 |
| `Eklee.KeyVault.UI/src/services/apiClient.ts` | +19 / –3 | High | 2 |

---

## Critical Issues

### Issue 1: `acquireTokenSilent` failure in the interceptor is unhandled — every API call will throw an unrecoverable error

**Severity**: Critical
**Category**: Error Handling
**File**: `Eklee.KeyVault.UI/src/services/apiClient.ts`
**Lines**: 26-36

#### Problem

`acquireTokenSilent` can reject with an `InteractionRequiredAuthError` (expired refresh token, revoked consent, new MFA requirement, etc.). The deleted `useAuthToken.ts` hook handled this by falling back to `acquireTokenRedirect`. The new interceptor has no error handling at all — a silent-token failure will bubble as an unhandled promise rejection and fail **every** subsequent API call with a cryptic MSAL error instead of redirecting the user to re-authenticate.
...

Success Indicators:

A summary of code review changes should be generated.

For detailed contribution requirements, see:

Testing

I used this for running code reviews in these 2 PRs

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

AI Artifact Contributions

  • Used /prompt-analyze to review contribution
  • Addressed all feedback from prompt-builder review
  • Verified contribution follows common standards and type-specific requirements

Required Automated Checks

The following validation commands must pass before merging:

  • Markdown linting: npm run lint:md
  • Spell checking: npm run spell-check
  • Frontmatter validation: npm run lint:frontmatter
  • Skill structure validation: npm run validate:skills
  • Link validation: npm run lint:md-links
  • PowerShell analysis: npm run lint:ps
  • Plugin freshness: npm run plugin:generate

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues
  • Security-related scripts follow the principle of least privilege

Additional Notes

@seekdavidlee seekdavidlee marked this pull request as ready for review February 22, 2026 21:23
@seekdavidlee seekdavidlee requested a review from a team as a code owner February 22, 2026 21:23
@WilliamBerryiii WilliamBerryiii changed the title Feat/646 functional code review agent feat(agents): Functional Code Review Agent — pre-PR functional correctness reviewer Feb 23, 2026
@WilliamBerryiii
Copy link
Copy Markdown
Member

Updated the PR title to match the conventional commit format from issue #646: feat(agents): Functional Code Review Agent — pre-PR functional correctness reviewer.

PR titles should use the conventional commit format (type(scope): description) rather than the branch name. This keeps the merge commit history consistent and readable.

@WilliamBerryiii
Copy link
Copy Markdown
Member

Great contribution — the functional correctness focus is valuable. A question on how this fits with the existing pre-PR tooling:

The /pull-request prompt already runs parallel subagent reviews on branch diffs (via the pr-reference skill) and produces a pr-reference-log.md with merged findings before generating the PR body. There's also the pr-review agent that does comprehensive post-PR review across multiple dimensions including functional correctness.

How do you see this agent interfacing with those existing workflows?

A few specific questions:

  1. Sequencing — Is the intent for developers to run this agent before invoking /pull-request, as a standalone pre-flight check? Or could it be integrated as one of the parallel subagents that /pull-request dispatches in Step 4?
  2. Overlap with pr-review — The pr-review.agent.md already covers functional correctness as one of its expert review dimensions. How does this agent differentiate — is it the narrower focus and pre-PR timing that's the value add?
  3. Output consumption — The output format (numbered severity-ordered issues with file/line/fix) is clean. Have you considered whether the /pull-request prompt could consume this output to auto-populate findings in the PR description, or is the intent to keep it as a separate developer-facing report?

Understanding the intended integration points would help evaluate the contribution and plan for any coordination across these tools.

@seekdavidlee
Copy link
Copy Markdown
Contributor Author

Great contribution — the functional correctness focus is valuable. A question on how this fits with the existing pre-PR tooling:

The /pull-request prompt already runs parallel subagent reviews on branch diffs (via the pr-reference skill) and produces a pr-reference-log.md with merged findings before generating the PR body. There's also the pr-review agent that does comprehensive post-PR review across multiple dimensions including functional correctness.

How do you see this agent interfacing with those existing workflows?

A few specific questions:

  1. Sequencing — Is the intent for developers to run this agent before invoking /pull-request, as a standalone pre-flight check? Or could it be integrated as one of the parallel subagents that /pull-request dispatches in Step 4?
  2. Overlap with pr-review — The pr-review.agent.md already covers functional correctness as one of its expert review dimensions. How does this agent differentiate — is it the narrower focus and pre-PR timing that's the value add?
  3. Output consumption — The output format (numbered severity-ordered issues with file/line/fix) is clean. Have you considered whether the /pull-request prompt could consume this output to auto-populate findings in the PR description, or is the intent to keep it as a separate developer-facing report?

Understanding the intended integration points would help evaluate the contribution and plan for any coordination across these tools.

Hi @WilliamBerryiii, please see below:

  1. Sequencing — The intent is for a developer to run this locally as opposed to when they are ready for PR. A developer might also need to run this a few times, as the agent is making changes.
  2. Overlap with pr-review — The PR agent as I understand it is working on several areas all at once. My hypothesis is that a narrow focus will produce a more targeted result. A developer might also just need to focus on one specific area as part of the local dev workflow.
  3. Output consumption — My thought right now is to keep it as a separate developer-facing report. A developer can review the list of issue and then tell the AI agent to resolve only the ones that matter. My hypothesis is that this agent will reduce the high/critical issues found by the PR review agent.

@WilliamBerryiii
Copy link
Copy Markdown
Member

@seekdavidlee - hang tight on this ... we will get it merged ... just need to finish up some stuff for the design thinking port first ... appreciate your patience and thanks for contributing.

@WilliamBerryiii
Copy link
Copy Markdown
Member

Hey @seekdavidlee 👋

We just merged main into your branch to bring it up to date. There was a minor conflict in plugins/hve-core-all/README.md where your new functional-code-review prompt row overlapped with a description update to dt-handoff-implementation-space that landed on main — resolved by keeping both your addition and the updated description.

Now that the Design Thinking changes have merged, we'll get this reviewed early next week. Thanks for your patience and the contribution! 🙏

@WilliamBerryiii WilliamBerryiii modified the milestones: v3.1.0, v3.2.0 Mar 1, 2026
@WilliamBerryiii WilliamBerryiii merged commit 9cf63b7 into microsoft:main Mar 2, 2026
24 checks passed
WilliamBerryiii added a commit that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[3.2.0](hve-core-v3.1.46...hve-core-v3.2.0)
(2026-03-20)


### ✨ Features

* add -OutputPath parameter to Validate-MarkdownFrontmatter.ps1
([#1134](#1134))
([fdf1bcf](fdf1bcf)),
closes [#1006](#1006)
* add action version consistency scan workflow
([#1127](#1127))
([4229df1](4229df1))
* **agent:** MVE Experiment Designer
([#976](#976))
([70f86ca](70f86ca))
* **agents:** add ADO Backlog Manager orchestrator agent
([#800](#800))
([fae3987](fae3987))
* **agents:** add meeting analyst agent for transcript analysis using
work-iq ([#502](#502))
([5345b5b](5345b5b))
* **agents:** add quick-reference line to RPI Phase 5 suggestions
([#897](#897))
([9a90f39](9a90f39))
* **agents:** add RAI Planner, enhance SSSC Planner, and redesign
Security Planner
([#979](#979))
([06f826c](06f826c))
* **agents:** add symmetric cross-system handoff to GitHub Backlog
Manager ([#952](#952))
([ba34a35](ba34a35))
* **agents:** Functional Code Review Agent — pre-PR functional
correctness reviewer
([#733](#733))
([9cf63b7](9cf63b7))
* **build:** add Python extensions and uv 0.10.8 to devcontainer
([#920](#920))
([9ca0579](9ca0579))
* **build:** add uv ecosystem to Dependabot configuration
([#913](#913))
([2a4bd39](2a4bd39))
* **build:** enable npm pinning enforcement in dependency scan
([#838](#838))
([4e9e31f](4e9e31f))
* **build:** migrate attestation actions to v4.1.0 and add SBOM
verification docs
([#841](#841))
([ca1e65b](ca1e65b))
* **collections:** add four new validator checks (orphan, duplicate,
companion, coverage)
([#869](#869))
([1a96b73](1a96b73))
* **devcontainer,security:** add enterprise artifact hub configuration
([#1032](#1032))
([1d56d25](1d56d25))
* **docs:** add Rust coding standards and guidelines
([#809](#809))
([d4c4899](d4c4899))
* **extension:** add Microsoft logo icon to VS Code Marketplace listings
([#906](#906))
([82aca41](82aca41))
* **github:** add declarative label management
([#953](#953))
([a1a6845](a1a6845))
* **instructions:** add ADO backlog shared infrastructure
([#786](#786))
([1914078](1914078))
* **instructions:** add ADO backlog sprint planning and capacity
tracking ([#788](#788))
([d6fb77d](d6fb77d))
* **instructions:** add ADO triage workflow and prompt
([#787](#787))
([cde0190](cde0190))
* **instructions:** add shared story quality conventions and sprint
planning ([#803](#803))
([a2f18e3](a2f18e3))
* **prompts:** add ADO discovery and work item prompts with agent
routing ([#790](#790))
([7e74523](7e74523))
* **prompts:** add security review prompts
([#1118](#1118))
([ad30967](ad30967))
* **scripts:** add dynamic Python skill discovery for lint/test
([#957](#957))
([0a90f57](0a90f57))
* **scripts:** add Get-StandardTimestamp utility to CIHelpers module
([#1126](#1126))
([b273a4b](b273a4b))
* **scripts:** add Python copyright header validation
([#905](#905))
([67df902](67df902))
* **scripts:** add Python skill support to Validate-SkillStructure
([#903](#903))
([68479d9](68479d9))
* **scripts:** add workflow npm command scanning to dependency pinning
([#837](#837))
([6b5ae06](6b5ae06))
* **security:** add basic security reviewer agent with owasp skills
([#1008](#1008))
([cb1fd05](cb1fd05))
* **security:** add sigstore attestation bundles and fix
component-detection action
([#1148](#1148))
([f79c272](f79c272))
* **skills:** add Atheris fuzz harness with CI workflow integration
([#1102](#1102))
([d337e1d](d337e1d))
* **skills:** add PowerPoint automation skill with YAML-driven deck
generation ([#868](#868))
([00465cd](00465cd))
* **skills:** convert hve-core-installer agent to self-contained skill
([#846](#846))
([1d821fb](1d821fb))
* **skills:** enhance pr-reference skill with flexible filtering and
base branch detection
([#1095](#1095))
([26a32ea](26a32ea))
* **workflows:** add devcontainer infrastructure change log workflow
([#899](#899))
([8aca446](8aca446))
* **workflows:** add milestone auto-close on stable and pre-release
publishes ([#834](#834))
([79362b1](79362b1))
* **workflows:** add ms.date documentation freshness checking
([#969](#969))
([3ed441c](3ed441c))
* **workflows:** add Python linting CI workflow with Ruff
([#951](#951))
([f89f0eb](f89f0eb))
* **workflows:** add Python testing CI workflow with pytest and Codecov
([#934](#934))
([5e8306f](5e8306f))
* **workflows:** add uv and Python package sync to copilot-setup-steps
([#921](#921))
([45d517d](45d517d))


### 🐛 Bug Fixes

* **build:** override Linguist vendored flag for Python skill files
([#1155](#1155))
([0eee5b6](0eee5b6))
* **build:** override serialize-javascript to >=7.0.3 for RCE fix
([#876](#876))
([e49039a](e49039a))
* **build:** resolve Pinned-Dependencies alerts for vsce npm commands in
extension workflows
([#782](#782))
([89dad9d](89dad9d))
* **build:** update undici and yauzl overrides for security audit
([#1030](#1030))
([2c2f92f](2c2f92f))
* **docs:** add CLI Plugins to install.md navigation surfaces
([#902](#902))
([79d6595](79d6595))
* **docs:** add sidebar ordering for Design Thinking documentation
([#832](#832))
([551fddc](551fddc)),
closes [#830](#830)
* **docs:** graduate design-thinking to preview and correct stale
collection references
([#831](#831))
([5110e35](5110e35))
* **docs:** include project-planning in UX Designer install guidance
([#908](#908))
([e7aa9bc](e7aa9bc))
* **docs:** remediate writing-style convention violations
([#865](#865))
([68b04bc](68b04bc))
* **docs:** remove draft content announcement banner
([#825](#825))
([b45de80](b45de80))
* **docs:** remove unbounded path-to-regexp override breaking SSG
([#1153](#1153))
([d810018](d810018))
* **docs:** use actual clone paths instead of folder display names in
multi-root workspace settings
([#984](#984))
([5dbab82](5dbab82))
* **instructions:** replace black with ruff in uv-projects
([#898](#898))
([b0c06d9](b0c06d9))
* **scripts:** cover .github/ skill files in copyright header validation
([#1055](#1055))
([#1098](#1098))
([27fbd33](27fbd33))
* **scripts:** eliminate phantom git changes from plugin generation
([#1035](#1035))
([e49a1b5](e49a1b5))
* **scripts:** enable JSON log output for lint:version-consistency
([#1033](#1033))
([52b0885](52b0885))
* **security:** calculate compliance score from total scanned
dependencies ([#930](#930))
([c112c3d](c112c3d))
* **skills:** add AST validation and namespace restriction for
content-extra.py
([#1027](#1027))
([c50c7a3](c50c7a3))
* **skills:** add depth limits to recursive PowerPoint processing
functions ([#1028](#1028))
([bf08994](bf08994))
* **skills:** harden XML parsing and blob writes in powerpoint extract
([#1053](#1053))
([89d24b1](89d24b1))
* **skills:** resolve ruff lint and format violations in powerpoint
skill ([#1048](#1048))
([17bbe7a](17bbe7a))
* **workflows:** add uv.lock dependencies submission have fork-skip
condition ([#1109](#1109))
([dec56ac](dec56ac))
* **workflows:** automate weekly SHA staleness check with issue creation
([#975](#975))
([1ea4caa](1ea4caa))
* **workflows:** close Codecov integration gaps for Pester and pytest
flags ([#1106](#1106))
([cca29b7](cca29b7))
* **workflows:** propagate uv sync errors in copilot-setup-steps
([#961](#961))
([df88d7c](df88d7c))
* **workflows:** resolve release-please skip cascade and Python project
discovery ([#1043](#1043))
([79993e2](79993e2))
* **workflows:** scan only commit subjects for breaking change detection
([#1157](#1157))
([a38a657](a38a657))


### 📚 Documentation

* clarify HVE Core Extension vs Installer messaging across documentation
([#965](#965))
([0fceb8f](0fceb8f))
* **docs:** add ADO integration user documentation
([#935](#935))
([ec89302](ec89302))
* **docs:** add Project Planning agent documentation
([#936](#936))
([3a3a0fd](3a3a0fd))
* **onboarding:** overhaul marketplace onboarding and documentation site
([#982](#982))
([4309e10](4309e10))


### ♻️ Refactoring

* **build:** merge code-review collection into coding-standards
([#863](#863))
([8027e7b](8027e7b))
* **workflows:** rename release pipeline workflows and add marketplace
automation triggers
([#829](#829))
([b6397f4](b6397f4))


### 🔧 Maintenance

* **build:** add clean:logs npm script
([#1122](#1122))
([f85fe02](f85fe02)),
closes [#988](#988)
* **build:** add JSON reporter for cspell
([#1123](#1123))
([6d59f67](6d59f67))
* **ci:** add multi-arch support to copilot-setup-steps binary downloads
([#955](#955))
([8d0c706](8d0c706))
* **deps-dev:** bump cspell from 9.6.4 to 9.7.0 in the npm-dependencies
group ([#839](#839))
([3fa16ff](3fa16ff))
* **deps:** bump actions/dependency-review-action from 4.8.3 to 4.9.0 in
the github-actions group across 1 directory
([#942](#942))
([1a9b858](1a9b858))
* **deps:** bump cairosvg from 2.8.2 to 2.9.0 in
/.github/skills/experimental/powerpoint
([#1025](#1025))
([f4deda7](f4deda7))
* **deps:** bump dompurify from 3.3.1 to 3.3.2 in /docs/docusaurus
([#924](#924))
([d2060d6](d2060d6))
* **deps:** bump svgo from 3.3.2 to 3.3.3 in /docs/docusaurus
([#880](#880))
([6dc2406](6dc2406))
* **deps:** bump the github-actions group across 1 directory with 4
updates ([#1100](#1100))
([2290dc0](2290dc0))
* **deps:** bump the github-actions group with 6 updates
([#840](#840))
([f57bc01](f57bc01))
* **docs:** correct New-MsDateReport table rendering and refresh stale
docs ([#1114](#1114))
([c2b806f](c2b806f))
* **settings:** remove orphaned Checkov config and stale gitignore
entries ([#870](#870))
([98fcd74](98fcd74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
Co-authored-by: Bill Berry <wberry@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(agents): Functional Code Review Agent — pre-PR functional correctness reviewer

2 participants