fix(scripts): cover .github/ skill files in copyright header validation (#1055) (#1098)

WilliamBerryiii · katriendg · web-flow · commit 27fbd33df1a8 · 2026-03-17T11:25:08.000+01:00
The copyright header validation script (`Test-CopyrightHeaders.ps1`) was silently skipping all files under `.github/` because: 1. **`Get-ChildItem` without `-Force`** did not enumerate dot-prefixed directories (`.github/`, `.venv/`) 2. **Wildcard substring matching** for exclusions (`-like "*$excludePath*"`) caused `.git` to inadvertently match `.github`, `.gitter`, `.gitbook`, etc. This PR fixes both root causes and adds SPDX/copyright headers to the 29 Python files that were missed. ### Changes - **Centralized `$DefaultExcludePaths`** — Single source of truth for default exclusions, referenced by both the script parameter and `Invoke-CopyrightHeaderCheck` - **Regex-based exclusion** — Replaced wildcard substring matching with path-separator-anchored regex (`[/\\](?:name)(?:[/\\]|$)`), preventing partial-prefix false matches - **`-Force` on `Get-ChildItem`** — Ensures dot-prefixed directories are enumerated - **13 new Pester tests** — Exclusion logic boundary tests and AST-based drift prevention tests - **29 Python files** — Added `# Copyright (c) Microsoft Corporation.` and `# SPDX-License-Identifier: MIT` headers ## Related Issue(s) Fixes #1055 ## Type of Change Select all that apply: **Code & Documentation:** * [x] Bug fix (non-breaking change fixing an issue) * [ ] New feature (non-breaking change adding functionality) * [ ] Breaking change (fix or feature causing existing functionality to change) * [ ] Documentation update **Infrastructure & Configuration:** * [ ] GitHub Actions workflow * [x] Linting configuration (markdown, PowerShell, etc.) * [ ] Security configuration * [ ] DevContainer configuration * [ ] Dependency update **AI Artifacts:** * [ ] Reviewed contribution with `prompt-builder` agent and addressed all feedback * [ ] Copilot instructions (`.github/instructions/*.instructions.md`) * [ ] Copilot prompt (`.github/prompts/*.prompt.md`) * [ ] Copilot agent (`.github/agents/*.agent.md`) * [ ] Copilot skill (`.github/skills/*/SKILL.md`) **Other:** * [x] Script/automation (`.ps1`, `.sh`, `.py`) * [ ] Other (please describe): ## Testing - **44 Pester tests passing** (31 existing + 13 new) covering: - Individual exclusion validation (`.git`, `.venv`, `.copilot-tracking`, `node_modules`) - Partial-prefix safety (`.git` not matching `.github`, `.gitter`, `.gitbook`) - `-Force` enumeration of dot-directories - Empty exclusions baseline, multiple simultaneous exclusions, deep nesting, custom paths, overlapping extensions - AST-based introspection verifying `$DefaultExcludePaths` contents and function parameter default alignment - **139/139 copyright headers passing** across all scanned files - **0 PSScriptAnalyzer findings** on changed scripts ## Checklist ### Required Checks * [x] Documentation is updated (if applicable) * [x] Files follow existing naming conventions * [x] Changes are backwards compatible (if applicable) * [x] Tests added for new functionality (if applicable) ### Required Automated Checks The following validation commands must pass before merging: * [x] Markdown linting: `npm run lint:md` * [x] Spell checking: `npm run spell-check` * [x] Frontmatter validation: `npm run lint:frontmatter` * [x] Skill structure validation: `npm run validate:skills` (pre-existing warnings only — `.pytest_cache`, `.ruff_cache`, `.venv` in powerpoint skill) * [x] Link validation: `npm run lint:md-links` (0 broken links) * [x] PowerShell analysis: `npm run lint:ps` * [ ] Plugin freshness: `npm run plugin:generate` (no plugin changes in this PR) ## Security Considerations * [x] This PR does not contain any sensitive or NDA information * [x] Any new dependencies have been reviewed for security issues * [x] Security-related scripts follow the principle of least privilege ## Additional Notes - Exclusion regex uses `[regex]::Escape()` on path names, preventing regex injection from exclusion entries. - The `-Force` fix was the primary root cause — without it, `Get-ChildItem` silently skips `.github/skills/` on Windows. --------- Co-authored-by: Katrien De Graeve <katriendg@users.noreply.github.com>
diff --git a/.github/skills/experimental/powerpoint/scripts/build_deck.py b/.github/skills/experimental/powerpoint/scripts/build_deck.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Build a PowerPoint slide deck from YAML content and style definitions.
 
 Usage::
diff --git a/.github/skills/experimental/powerpoint/scripts/export_slides.py b/.github/skills/experimental/powerpoint/scripts/export_slides.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Export PowerPoint slides to PDF with optional slide filtering.
 
 Converts a PPTX file to PDF using LibreOffice headless mode. When specific
diff --git a/.github/skills/experimental/powerpoint/scripts/extract_content.py b/.github/skills/experimental/powerpoint/scripts/extract_content.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Extract content from an existing PPTX into YAML content and style definitions.
 
 Usage::
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_charts.py b/.github/skills/experimental/powerpoint/scripts/pptx_charts.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Chart build and extract utilities for PowerPoint skill scripts.
 
 Provides add_chart_element() for building charts from YAML definitions
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_colors.py b/.github/skills/experimental/powerpoint/scripts/pptx_colors.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Color resolution and conversion utilities for PowerPoint skill scripts.
 
 Supports #RRGGBB hex values and @theme_name references for theme colors.
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_fills.py b/.github/skills/experimental/powerpoint/scripts/pptx_fills.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Fill and line application/extraction utilities for PowerPoint skill scripts.
 
 Handles solid, gradient, and pattern fills plus line/border properties.
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_fonts.py b/.github/skills/experimental/powerpoint/scripts/pptx_fonts.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Font normalization, matching, and extraction utilities.
 
 Centralizes font-related constants and functions used by
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_shapes.py b/.github/skills/experimental/powerpoint/scripts/pptx_shapes.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Shape constants, maps, and rotation utilities for PowerPoint skill scripts.
 
 Provides the expanded SHAPE_MAP (30+ entries), an inverse AUTO_SHAPE_NAME_MAP
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_tables.py b/.github/skills/experimental/powerpoint/scripts/pptx_tables.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Table build and extract utilities for PowerPoint skill scripts.
 
 Provides add_table_element() for building tables from YAML definitions
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_text.py b/.github/skills/experimental/powerpoint/scripts/pptx_text.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Text frame, paragraph, and run property utilities for PowerPoint skill scripts.
 
 Centralizes text properties (margins, auto-size, spacing, underline,
diff --git a/.github/skills/experimental/powerpoint/scripts/pptx_utils.py b/.github/skills/experimental/powerpoint/scripts/pptx_utils.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Shared utilities for PowerPoint skill scripts.
 
 Provides YAML loading, EMU conversion, and validation helpers used by
diff --git a/.github/skills/experimental/powerpoint/scripts/render_pdf_images.py b/.github/skills/experimental/powerpoint/scripts/render_pdf_images.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Render PDF pages to JPG images using PyMuPDF.
 
 Converts each page of a PDF file to a JPG image at the specified DPI.
diff --git a/.github/skills/experimental/powerpoint/scripts/validate_deck.py b/.github/skills/experimental/powerpoint/scripts/validate_deck.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Validate PPTX properties that cannot be detected from rendered images.
 
 Checks speaker notes and slide count. Visual checks (overlay, overflow,
diff --git a/.github/skills/experimental/powerpoint/scripts/validate_slides.py b/.github/skills/experimental/powerpoint/scripts/validate_slides.py
@@ -1,4 +1,5 @@
-#!/usr/bin/env python3
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Validate slide images using Copilot SDK vision models.
 
 Sends each rendered slide image to a vision-capable model via the
diff --git a/.github/skills/experimental/powerpoint/tests/conftest.py b/.github/skills/experimental/powerpoint/tests/conftest.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Shared fixtures for PowerPoint skill tests."""
 
 import struct
diff --git a/.github/skills/experimental/powerpoint/tests/test_build_deck.py b/.github/skills/experimental/powerpoint/tests/test_build_deck.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for build_deck module."""
 
 from unittest.mock import MagicMock, patch
diff --git a/.github/skills/experimental/powerpoint/tests/test_export_slides.py b/.github/skills/experimental/powerpoint/tests/test_export_slides.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for export_slides module.
 
 Tests mock subprocess and shutil for LibreOffice interaction and fitz for
diff --git a/.github/skills/experimental/powerpoint/tests/test_extract_content.py b/.github/skills/experimental/powerpoint/tests/test_extract_content.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for extract_content module."""
 
 from collections import Counter
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_charts.py b/.github/skills/experimental/powerpoint/tests/test_pptx_charts.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_charts module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_colors.py b/.github/skills/experimental/powerpoint/tests/test_pptx_colors.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_colors module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_fills.py b/.github/skills/experimental/powerpoint/tests/test_pptx_fills.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_fills module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_fonts.py b/.github/skills/experimental/powerpoint/tests/test_pptx_fonts.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_fonts module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_shapes.py b/.github/skills/experimental/powerpoint/tests/test_pptx_shapes.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_shapes module."""
 
 from pptx.enum.shapes import MSO_SHAPE
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_tables.py b/.github/skills/experimental/powerpoint/tests/test_pptx_tables.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_tables module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_text.py b/.github/skills/experimental/powerpoint/tests/test_pptx_text.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_text module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_pptx_utils.py b/.github/skills/experimental/powerpoint/tests/test_pptx_utils.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for pptx_utils module."""
 
 import pytest
diff --git a/.github/skills/experimental/powerpoint/tests/test_render_pdf_images.py b/.github/skills/experimental/powerpoint/tests/test_render_pdf_images.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for render_pdf_images module.
 
 Tests mock PyMuPDF (fitz) since it may not be installed in all environments.
diff --git a/.github/skills/experimental/powerpoint/tests/test_validate_deck.py b/.github/skills/experimental/powerpoint/tests/test_validate_deck.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for validate_deck module."""
 
 import json
diff --git a/.github/skills/experimental/powerpoint/tests/test_validate_slides.py b/.github/skills/experimental/powerpoint/tests/test_validate_slides.py
@@ -1,3 +1,5 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
 """Tests for validate_slides module.
 
 The validate_slides module depends on the Copilot SDK for vision model
diff --git a/scripts/linting/Test-CopyrightHeaders.ps1 b/scripts/linting/Test-CopyrightHeaders.ps1
@@ -66,7 +66,7 @@ param(
     [switch]$FailOnMissing,
 
     [Parameter(Mandatory = $false)]
-    [string[]]$ExcludePaths = @('node_modules', '.git', 'vendor', 'logs')
+    [string[]]$ExcludePaths
 )
 
 # Import shared helpers if available
@@ -76,6 +76,13 @@ if (Test-Path $helpersPath) {
 }
 Import-Module (Join-Path $PSScriptRoot "../lib/Modules/CIHelpers.psm1") -Force
 
+# Canonical default exclusions shared between script-level param and Invoke-CopyrightHeaderCheck
+$DefaultExcludePaths = @('node_modules', '.git', 'vendor', 'logs', '.venv', '.copilot-tracking')
+
+if (-not $PSBoundParameters.ContainsKey('ExcludePaths')) {
+    $ExcludePaths = $DefaultExcludePaths
+}
+
 # Header patterns to check
 $CopyrightPattern = '^\s*#\s*Copyright\s*\(c\)\s*Microsoft\s+Corporation\.?\s*$'
 $SpdxPattern = '^\s*#\s*SPDX-License-Identifier:\s*MIT\s*$'
@@ -142,19 +149,21 @@ function Get-FilesToCheck {
 
     $files = @()
 
+    $excludeRegex = $null
+    $validExcludes = @($Exclude | Where-Object { $_ })
+    if ($validExcludes.Count -gt 0) {
+        $sepPattern = '[/\\]'
+        $excludeAlternation = ($validExcludes | ForEach-Object { [regex]::Escape($_) }) -join '|'
+        $excludeRegex = "${sepPattern}(?:${excludeAlternation})(?:${sepPattern}|$)"
+    }
+
     foreach ($ext in $Extensions) {
-        $found = Get-ChildItem -Path $RootPath -Filter $ext -Recurse -File -ErrorAction SilentlyContinue |
-            Where-Object {
-                $filePath = $_.FullName
-                $excluded = $false
-                foreach ($excludePath in $Exclude) {
-                    if ($filePath -like "*$excludePath*") {
-                        $excluded = $true
-                        break
-                    }
-                }
-                -not $excluded
-            }
+        $found = Get-ChildItem -Path $RootPath -Filter $ext -Recurse -File -Force -ErrorAction SilentlyContinue
+
+        if ($excludeRegex) {
+            $found = $found | Where-Object { $_.FullName -notmatch $excludeRegex }
+        }
+
         $files += $found
     }
 
@@ -178,7 +187,7 @@ function Invoke-CopyrightHeaderCheck {
         [switch]$FailOnMissing,
 
         [Parameter(Mandatory = $false)]
-        [string[]]$ExcludePaths = @('node_modules', '.git', 'vendor', 'logs')
+        [string[]]$ExcludePaths = $script:DefaultExcludePaths
     )
 
     Write-Host "📄 Validating copyright headers..." -ForegroundColor Cyan
diff --git a/scripts/tests/linting/Test-CopyrightHeaders.Tests.ps1 b/scripts/tests/linting/Test-CopyrightHeaders.Tests.ps1

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# Copyright (c) Microsoft Corporation.`
	`2`	`+# SPDX-License-Identifier: MIT`
`1`	`3`	`"""Build a PowerPoint slide deck from YAML content and style definitions.`
`2`	`4`
`3`	`5`	`Usage::`